Paths

Table of Contentst

[services] Tunnelbroker - Avoid listing all entities in DatabaseEntities.
ClosedPublic
Actions

Authored by • max on Mar 28 2022, 11:32 AM.

Details

Reviewers

• karol
tomek
• jim

Commits

rCOMM4b3a25af06b7: [services] Tunnelbroker - Avoid listing all entities in DatabaseEntities.

Summary

Avoid listing all entities in DatabaseEntitiesTools.h and use a new approach like we already use in a Blob service.

Related linear task: ENG-706

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Mar 28 2022, 11:32 AM

Herald added subscribers: • benschac, • karol, atul and 3 others. · View Herald TranscriptMar 28 2022, 11:32 AM

• max edited the summary of this revision. (Show Details)Mar 28 2022, 11:34 AM

• max added reviewers: • karol, tomek, • jim.

• max added 1 blocking reviewer(s): tomek.

Harbormaster completed remote builds in B7638: Diff 10726.Mar 28 2022, 11:44 AM

• max requested review of this revision.Mar 28 2022, 11:44 AM

Nice!

This revision is now accepted and ready to land.Mar 28 2022, 12:37 PM

• karol accepted this revision.Mar 28 2022, 1:10 PM

Rebase on master.

This revision was landed with ongoing or failed builds.Mar 28 2022, 3:26 PM

Closed by commit rCOMM4b3a25af06b7: [services] Tunnelbroker - Avoid listing all entities in DatabaseEntities.. · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM4b3a25af06b7: [services] Tunnelbroker - Avoid listing all entities in DatabaseEntities..

Harbormaster completed remote builds in B7648: Diff 10742.Mar 28 2022, 3:34 PM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Database/

DatabaseEntitiesTools.h

13 lines

DatabaseEntitiesTools.cpp

Diff 10743

View Options

services/tunnelbroker/src/Database/DatabaseEntitiesTools.h