Page MenuHomePhabricator
Differential D3524

[services] Tunnelbroker - Avoid listing all entities in DatabaseEntities.
ClosedPublic
Actions

Authored by • max on Mar 28 2022, 4:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 9:35 PM
Unknown Object (File)
Fri, Mar 14, 10:35 PM
Unknown Object (File)
Fri, Mar 14, 10:34 PM
Unknown Object (File)
Feb 26 2025, 9:42 AM
Unknown Object (File)
Feb 24 2025, 8:50 PM
Unknown Object (File)
Feb 5 2025, 4:00 PM
Unknown Object (File)
Jan 27 2025, 11:44 PM
Unknown Object (File)
Jan 27 2025, 6:30 PM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
• jim
Commits
rCOMM4b3a25af06b7: [services] Tunnelbroker - Avoid listing all entities in DatabaseEntities.
Summary

Avoid listing all entities in DatabaseEntitiesTools.h and use a new approach like we already use in a Blob service.

Related linear task: ENG-706

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Mar 28 2022, 4:32 AM
Herald added subscribers: • benschac, • karol, atul and 3 others. · View Herald TranscriptMar 28 2022, 4:32 AM
• max edited the summary of this revision. (Show Details)Mar 28 2022, 4:34 AM
• max added reviewers: • karol, tomek, • jim.
• max added 1 blocking reviewer(s): tomek.
Harbormaster completed remote builds in B7638: Diff 10726.Mar 28 2022, 4:44 AM
• max requested review of this revision.Mar 28 2022, 4:44 AM
tomek accepted this revision.Mar 28 2022, 5:37 AM

Nice!

This revision is now accepted and ready to land.Mar 28 2022, 5:37 AM
• karol accepted this revision.Mar 28 2022, 6:10 AM
• max updated this revision to Diff 10742.Mar 28 2022, 8:25 AM

Rebase on master.

This revision was landed with ongoing or failed builds.Mar 28 2022, 8:26 AM
Closed by commit rCOMM4b3a25af06b7: [services] Tunnelbroker - Avoid listing all entities in DatabaseEntities. (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM4b3a25af06b7: [services] Tunnelbroker - Avoid listing all entities in DatabaseEntities..
Harbormaster completed remote builds in B7648: Diff 10742.Mar 28 2022, 8:34 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Database/
13 lines

Diff 10743

View Options

services/tunnelbroker/src/Database/DatabaseEntitiesTools.h

div.headerContainer { div.loginContainer {
flex: 1 1 auto;
padding: 0 10px;
}
div.headerContents {
display: flex; display: flex;
justify-content: space-between; justify-content: center;
align-items: center;
padding-top: 5px;
padding-bottom: 7px;
}
div.actionLinks > * {
padding-right: 15px;
color: white;
font-weight: 300;
}
div.actionLinks > *:last-child {
padding-right: 0;
}
header.header h1 {
color: white; color: white;
font-size: 38px;
}
header.header {
padding: 10px 20px;
border-radius: 20px;
border: 1px solid white;
} }
View Options

services/tunnelbroker/src/Database/DatabaseEntitiesTools.cpp

div.headerContainer { div.loginContainer {
flex: 1 1 auto;
padding: 0 10px;
}
div.headerContents {
display: flex; display: flex;
justify-content: space-between; justify-content: center;
align-items: center;
padding-top: 5px;
padding-bottom: 7px;
}
div.actionLinks > * {
padding-right: 15px;
color: white;
font-weight: 300;
}
div.actionLinks > *:last-child {
padding-right: 0;
}
header.header h1 {
color: white; color: white;
font-size: 38px;
}
header.header {
padding: 10px 20px;
border-radius: 20px;
border: 1px solid white;
} }