[server] Reorder Express routers
ClosedPublic
Actions

Authored by ashoat on Mar 30 2022, 12:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 4, 4:40 PM

	Unknown Object (File)
	Fri, Oct 4, 4:40 PM

	Unknown Object (File)
	Fri, Oct 4, 4:40 PM

	Unknown Object (File)
	Fri, Oct 4, 4:38 PM

	Unknown Object (File)
	Wed, Sep 18, 7:09 PM

	Unknown Object (File)
	Sep 5 2024, 12:22 PM

	Unknown Object (File)
	Aug 28 2024, 8:13 AM

	Unknown Object (File)
	Aug 26 2024, 5:22 PM

Subscribers

Details

Reviewers

varun

Commits

rCOMMdcd0a2c4afbb: [server] Reorder Express routers

Summary

The order of these matters - see code comment.

Test Plan

I actually tested reordering these live on prod, and it worked

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 30 2022, 12:13 PM

Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptMar 30 2022, 12:13 PM

Harbormaster completed remote builds in B7729: Diff 10843.Mar 30 2022, 12:20 PM

ashoat requested review of this revision.Mar 30 2022, 12:20 PM

varun accepted this revision.Mar 30 2022, 12:45 PM

This revision is now accepted and ready to land.Mar 30 2022, 12:45 PM

Closed by commit rCOMMdcd0a2c4afbb: [server] Reorder Express routers (authored by ashoat). · Explain WhyMar 30 2022, 5:41 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdcd0a2c4afbb: [server] Reorder Express routers.

Revision Contents
Changeset List

Path

Size

server/

src/

server.js

21 lines

Diff 10851

View Options

[server] Reorder Express routersClosedPublicActions