[server] Rename clientURLFromLocalURL to clientPathFromRouterPath
ClosedPublic
Actions

Authored by ashoat on Mar 30 2022, 11:08 PM.

Tags

None

Referenced Files

	F2193133: D3580.id10913.diff
	Thu, Jul 4, 9:13 PM

	Unknown Object (File)
	Thu, Jun 27, 9:24 PM

	Unknown Object (File)
	Wed, Jun 26, 7:13 PM

	Unknown Object (File)
	Mon, Jun 24, 6:17 PM

	Unknown Object (File)
	Mon, Jun 24, 1:10 AM

	Unknown Object (File)
	Fri, Jun 21, 11:58 PM

	Unknown Object (File)
	Fri, Jun 21, 11:58 PM

	Unknown Object (File)
	Fri, Jun 21, 11:57 PM

Subscribers

Details

Reviewers

varun

Commits

rCOMM180b14b8e8f2: [server] Rename clientURLFromLocalURL to clientPathFromRouterPath

Summary

We want to be clear that the input is a path relative to a specific Express router, and the outside is a path that the client can understand.

Response to @varun's feedback on D3554.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 30 2022, 11:08 PM

Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptMar 30 2022, 11:08 PM

ashoat mentioned this in D3554: [server] Factor out clientURLFromLocalURL so it can be reused in website-responders.js.Mar 30 2022, 11:09 PM

Harbormaster completed remote builds in B7738: Diff 10854.Mar 30 2022, 11:15 PM

ashoat requested review of this revision.Mar 30 2022, 11:15 PM

varun accepted this revision.Mar 31 2022, 5:51 AM

This revision is now accepted and ready to land.Mar 31 2022, 5:51 AM

Closed by commit rCOMM180b14b8e8f2: [server] Rename clientURLFromLocalURL to clientPathFromRouterPath (authored by ashoat). · Explain WhyMar 31 2022, 10:38 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM180b14b8e8f2: [server] Rename clientURLFromLocalURL to clientPathFromRouterPath.

Revision Contents
Changeset List

Path

Size

server/

src/

responders/

landing-handler.js

6 lines

website-responders.js

6 lines

utils/

urls.js

9 lines

Diff 10913

View Options

server/src/responders/landing-handler.js

View Options

server/src/responders/website-responders.js

View Options

[server] Rename clientURLFromLocalURL to clientPathFromRouterPathClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10913

server/src/responders/landing-handler.js

server/src/responders/website-responders.js

server/src/utils/urls.js

[server] Rename clientURLFromLocalURL to clientPathFromRouterPath
ClosedPublic
Actions

Revision Contents
Changeset List