Page MenuHomePhabricator
Differential D3588

[web] Remove duplicate CSS properties within same selector
ClosedPublic
Actions

Authored by atul on Mar 31 2022, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 1:18 PM
Unknown Object (File)
Wed, Jun 26, 6:05 PM
Unknown Object (File)
Wed, Jun 26, 6:05 PM
Unknown Object (File)
Wed, Jun 26, 6:05 PM
Unknown Object (File)
Wed, Jun 26, 6:05 PM
Unknown Object (File)
Wed, Jun 26, 6:05 PM
Unknown Object (File)
Wed, Jun 26, 6:04 PM
Unknown Object (File)
Wed, Jun 26, 5:57 PM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
• benschac
tomek
ashoat
Commits
rCOMM6e12d409de58: [web] Remove duplicate CSS properties within same selector
Summary

Kept running across duplicate properties in CSS selectors and "sneaking in" their removal into other diffs. Just went ahead and cut all of them.

The last instance of the property within the selector is what "wins," so I just cut the instances that came before.

Test Plan

Shouldn't make a difference, basically no-op.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 31 2022, 10:22 AM
Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMar 31 2022, 10:22 AM
Harbormaster completed remote builds in B7778: Diff 10912.Mar 31 2022, 10:32 AM
atul requested review of this revision.Mar 31 2022, 10:32 AM
atul retitled this revision from [web] Remove duplicate properties to [web] Remove duplicate CSS properties within same selector.Mar 31 2022, 10:41 AM
• benschac requested changes to this revision.Mar 31 2022, 10:57 AM

Can you add a screenshot of each of these components you're changing?

This revision now requires changes to proceed.Mar 31 2022, 10:57 AM
atul requested review of this revision.EditedMar 31 2022, 11:28 AM

Can you add a screenshot of each of these components you're changing?

Nothing should change visually since the last redundant property "wins," and I only removed the earlier instance of the property.

See:

Screen Shot 2022-03-31 at 2.26.36 PM.png (662×3 px, 267 KB)

ashoat accepted this revision.Mar 31 2022, 8:52 PM
• benschac accepted this revision.Apr 1 2022, 8:17 AM
This revision is now accepted and ready to land.Apr 1 2022, 8:17 AM
atul updated this revision to Diff 11024.Apr 4 2022, 2:21 PM

rebase before landing

Harbormaster completed remote builds in B7851: Diff 11024.Apr 4 2022, 2:33 PM
atul updated this revision to Diff 11026.Apr 4 2022, 2:40 PM

rebase before landing

atul updated this revision to Diff 11027.Apr 4 2022, 2:43 PM

rebase

This revision was landed with ongoing or failed builds.Apr 4 2022, 2:44 PM
Closed by commit rCOMM6e12d409de58: [web] Remove duplicate CSS properties within same selector (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6e12d409de58: [web] Remove duplicate CSS properties within same selector.
Harbormaster failed remote builds in B7853: Diff 11026!Apr 4 2022, 2:45 PM
Harbormaster completed remote builds in B7854: Diff 11027.Apr 4 2022, 2:54 PM

Revision Contents
Changeset List

PathSize
web/
calendar/
2 lines
chat/
1 line
markdown/
1 line
modals/
account/
1 line
1 line

Diff 11028

View Options

web/calendar/filter-panel.css

Loading...
View Options

web/chat/chat-input-bar.css

Loading...
View Options

web/markdown/markdown.css

Loading...
View Options

web/modals/account/user-settings-modal.css

Loading...
View Options

web/style.css

Loading...