Paths

Table of Contentst

[web] Added `LoadingIndicator` to `LoginForm` "Log in" button
ClosedPublic
Actions

Authored by • abosh on Apr 1 2022, 5:21 PM.

Details

Reviewers

atul
ashoat

Commits

rCOMMe58dcfdca205: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button

Summary

Added spinning LoadingIndicator to "Log in" button on login screen. More context on Linear.

Video:

Test Plan

Logged out and logged in multiple times on Chrome/Safari and ensured everything worked, covering cases where both login failed and login succeeded.

Diff Detail

Repository

rCOMM Comm

Branch

wordmark-homepage (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Apr 1 2022, 5:21 PM

Herald added subscribers: • benschac, • karol, • adrian and 2 others. · View Herald TranscriptApr 1 2022, 5:21 PM

Harbormaster completed remote builds in B7811: Diff 10975.Apr 1 2022, 5:27 PM

• abosh requested review of this revision.Apr 1 2022, 5:27 PM

• abosh edited the summary of this revision. (Show Details)Apr 1 2022, 5:55 PM

• abosh edited the test plan for this revision. (Show Details)

ashoat added inline comments.Apr 1 2022, 7:24 PM

web/account/log-in-form.react.js
147 ↗	(On Diff #10975)	Prefer not to use ternary conditions that return JSX elements like this Details here

• abosh added 1 blocking reviewer(s): atul.Apr 1 2022, 8:29 PM

Removed ternary condition that returned JSX element and used function instead.

• abosh planned changes to this revision.Apr 3 2022, 11:50 PM

Harbormaster completed remote builds in B7813: Diff 10977.Apr 4 2022, 11:10 AM

Removed function and used conditional rendering outside of JSX, per https://beta.reactjs.org/learn#conditional-rendering

Harbormaster failed remote builds in B7852: Diff 11025!Apr 4 2022, 2:34 PM

atul accepted this revision.Apr 4 2022, 2:49 PM

This revision is now accepted and ready to land.Apr 4 2022, 2:49 PM

atul added a reviewer: ashoat.Apr 4 2022, 2:49 PM

This revision now requires review to proceed.Apr 4 2022, 2:49 PM

ashoat accepted this revision.Apr 5 2022, 1:04 AM

This revision is now accepted and ready to land.Apr 5 2022, 1:04 AM

Harbormaster completed remote builds in B7852: Diff 11025.Apr 6 2022, 10:12 AM

Closed by commit rCOMMe58dcfdca205: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button (authored by • abosh). · Explain WhyApr 6 2022, 10:17 AM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMMe58dcfdca205: [web] Added `LoadingIndicator` to `LoginForm` "Log in" button.

• abosh mentioned this in D4287: [web] Add `LoadingIndicator` to `ThreadSettingsGeneralTab` Save button.Jun 16 2022, 1:55 PM

• abosh mentioned this in rCOMM98cd7aeceb61: [web] Add `LoadingIndicator` to `ThreadSettingsGeneralTab` Save button.Jun 18 2022, 2:11 PM

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.css

5 lines

log-in-form.react.js

10 lines

Diff 11025

View Options

web/account/log-in-form.css