Differential D3613

[web] [refactor] [ENG-716] destructure props in confirm-leave-thread-modal
ClosedPublic
Actions

Authored by • benschac on Apr 4 2022, 12:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 8:11 AM

	Unknown Object (File)
	Thu, Nov 14, 4:35 PM

	Unknown Object (File)
	Sun, Nov 10, 11:43 PM

	Unknown Object (File)
	Fri, Nov 8, 7:31 AM

	Unknown Object (File)
	Sun, Nov 3, 3:20 PM

	Unknown Object (File)
	Sun, Nov 3, 3:20 PM

	Unknown Object (File)
	Sun, Nov 3, 3:20 PM

	Unknown Object (File)
	Sun, Nov 3, 3:20 PM

Subscribers

Details

Reviewers

Commits

rCOMMd04163e9c8f7: [web] [refactor] [ENG-716] destructure props in confirm-leave-thread-modal

Summary

just moving props to a destructure on top of file

https://linear.app/comm/issue/ENG-716/introduce-leave-channel-modal

Test Plan

click leave button

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Apr 4 2022, 12:59 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 4 2022, 12:59 PM

• benschac edited the summary of this revision. (Show Details)Apr 4 2022, 1:00 PM

Harbormaster completed remote builds in B7846: Diff 11016.Apr 4 2022, 1:06 PM

• benschac requested review of this revision.Apr 4 2022, 1:06 PM

• benschac added a child revision: D3614: [web] [feat] [ENG-716] update copy on modal for design review.Apr 4 2022, 1:49 PM

atul accepted this revision.Apr 5 2022, 12:21 PM

atul added inline comments.

web/modals/threads/confirm-leave-thread-modal.react.js
18 ↗	(On Diff #11016)	Personally find the second-level destructuring syntax to be weird, but that's how it is. Would maybe prefer like const {threadInfo, onClose, onConfirm} = props; const {uiName} = threadInfo; but it doesn't matter

This revision is now accepted and ready to land.Apr 5 2022, 12:21 PM

fix thing

This revision was landed with ongoing or failed builds.Apr 5 2022, 1:29 PM

Closed by commit rCOMMd04163e9c8f7: [web] [refactor] [ENG-716] destructure props in confirm-leave-thread-modal (authored by • benschac). · Explain Why

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMd04163e9c8f7: [web] [refactor] [ENG-716] destructure props in confirm-leave-thread-modal.

Harbormaster completed remote builds in B7902: Diff 11080.Apr 5 2022, 1:35 PM

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

confirm-leave-thread-modal.react.js

9 lines

Diff 11081

web/modals/threads/confirm-leave-thread-modal.react.js

Loading...