[docs] Fix `generate-olm-config.js` script in `dev_environment` docs
ClosedPublic
Actions

Authored by atul on Apr 5 2022, 11:12 AM.

Details

Reviewers

tomek
ashoat
• benschac
• abosh

Commits

rCOMMad6d2646d751: [docs] Fix `generate-olm-config.js` script in `dev_environment` docs

Summary

filename suffix should've been .js not .json

Test Plan

didn't work before, now it does work

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 5 2022, 11:12 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptApr 5 2022, 11:12 AM

Harbormaster completed remote builds in B7892: Diff 11069.Apr 5 2022, 11:18 AM

atul requested review of this revision.Apr 5 2022, 11:18 AM

ashoat accepted this revision.Apr 5 2022, 7:25 PM

This revision is now accepted and ready to land.Apr 5 2022, 7:25 PM

I think I saw @yayabosh mention this in one of the tasks he created relating to the dev environment instructions

Yup, it should be yarn script dist/scripts/generate-olm-config.js because the JSON file does not exist, and it looks like that was the change that was made!

Closed by commit rCOMMad6d2646d751: [docs] Fix `generate-olm-config.js` script in `dev_environment` docs (authored by atul). · Explain WhyApr 6 2022, 11:14 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMad6d2646d751: [docs] Fix `generate-olm-config.js` script in `dev_environment` docs.

Revision Contents
Changeset List

Path

Size

docs/

dev_environment.md

2 lines

Diff 11069

View Options

[docs] Fix `generate-olm-config.js` script in `dev_environment` docsClosedPublicActions