We discussed this a bit ago in the Comm Dev Team chat, noop
Details
Details
careful reading, things continue to look the same at a glance
Went through every occurrence of "css" in ThreadSettingsModal and changed the selector names to underscore from dash.
The two occurrences of CSS selectors in ThreadSettingsModal that still have dashes are current-tab and modal-radio-selector. These don't exist in the CSS yet and are left over from before (where it was also broken).
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- april8 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Can you be more specific in your test plan? Did you grep for each usage of the old style?
Comment Actions
Did you grep for each usage of the old style?
The styles in thread-settings-modal.css are exclusively imported and used by the ThreadSettingsModal component.
But yeah, went through every occurrence of "css" in ThreadSettingsModal and changed the selector names to underscore from dash.
The two occurrences of CSS selectors in ThreadSettingsModal that still have dashes are current-tab and modal-radio-selector. These don't exist in the CSS yet and are left over from before (where it was also broken).