[web] [fix] [ENG-965] calendar hover history + add show on hover
ClosedPublic
Actions

Authored by • benschac on Apr 6 2022, 1:07 PM.

Details

Reviewers

atul
tomek
• jacek

Commits

rCOMM7493f1a8982a: [web] [fix] [ENG-965] calendar hover history + add show on hover

Summary

on hover, add and history prompt are now visible
https://linear.app/comm/issue/ENG-965/calendar-buttons-only-visible-on-hover

Screen Recording 2022-04-06 at 04.07.53 PM.gif (484×1 px, 275 KB)

Test Plan

hover over days on the calendar

Diff Detail

Repository

rCOMM Comm

Branch

history-buttons

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 6 2022, 1:07 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 6 2022, 1:07 PM

• benschac edited the summary of this revision. (Show Details)Apr 6 2022, 1:10 PM

• benschac edited the summary of this revision. (Show Details)

• benschac added reviewers: tomek, • jacek.

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 6 2022, 1:12 PM

Harbormaster failed remote builds in B7936: Diff 11123!

• benschac requested review of this revision.Apr 6 2022, 1:16 PM

Harbormaster completed remote builds in B7936: Diff 11123.Apr 6 2022, 2:10 PM

We had two colors previously and now we're replacing them with only one color - is there a reason for that?

This revision now requires changes to proceed.Apr 6 2022, 11:12 PM

There isn't a reason. We don't have design for the calendar. The ticket specifically said:

they would either always appear, or they would both appear on hover over the calendar day (rather than specifically on hover over the button). The current approach is bad because there is no indication to the user that a button will appear when they hover over a specific part of the screen.

This just makes the buttons appear on hover. Rather than adding another color that we'd possibly have churn over picking.

• benschac requested review of this revision.Apr 7 2022, 8:08 AM

tomek accepted this revision.Apr 7 2022, 11:37 PM

This revision is now accepted and ready to land.Apr 7 2022, 11:37 PM

Closed by commit rCOMM7493f1a8982a: [web] [fix] [ENG-965] calendar hover history + add show on hover (authored by • benschac). · Explain WhyApr 8 2022, 6:43 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM7493f1a8982a: [web] [fix] [ENG-965] calendar hover history + add show on hover.