Page MenuHomePhabricator

[web] [fix] [ENG-731] update thread selected state text
ClosedPublic

Authored by benschac on Apr 11 2022, 11:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:54 PM
Unknown Object (File)
Mon, Nov 18, 3:05 PM
Unknown Object (File)
Sat, Nov 16, 10:22 PM
Unknown Object (File)
Fri, Nov 15, 9:05 AM
Unknown Object (File)
Thu, Nov 14, 8:59 AM
Unknown Object (File)
Sun, Nov 3, 2:54 PM
Unknown Object (File)
Sun, Nov 3, 2:54 PM
Unknown Object (File)
Sun, Nov 3, 2:54 PM

Details

Summary
Test Plan

select a chat thread list item on web

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested changes to this revision.Apr 12 2022, 9:49 AM

change text color per issue and conversation with ashoat.

It's hard to verify the diff when we don't know what was agreed. It is probably described on linear - the comment says that:

Talked IRL with @ashoat, settled on var(--shades-of-white-60); for the selected text color of the chat thread list item.

But it looks like on current master the value of --thread-color-read is --thread-color-read: var(--shades-black-60). Does the value of --thread-color-read changes in one of your diffs? This diff isn't a part of a stack so it shouldn't depend on anything else.

This revision now requires changes to proceed.Apr 12 2022, 9:49 AM

ty for catching this! you're 100% right:

Image 2022-04-18 at 9.25.19 AM.jpg (386×746 px, 33 KB)

updated the selected text color to var(shades-of-white-60)

This revision is now accepted and ready to land.Apr 19 2022, 2:36 AM