[web] [fix] [ENG-731] update thread selected state text
ClosedPublic
Actions

Authored by • benschac on Apr 11 2022, 11:44 AM.

Details

Reviewers

atul
tomek
• jacek

Commits

rCOMMd77f80b11afb: [web] [fix] [ENG-731] update thread selected state text

Summary

change text color per issue and conversation with ashoat.
https://linear.app/comm/issue/ENG-731/appearance-of-thread-selected-state-makes-it-look-unread

Image 2022-04-11 at 2.45.31 PM.jpg (370×882 px, 33 KB)

Test Plan

select a chat thread list item on web

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D3698

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 11 2022, 11:44 AM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 11 2022, 11:44 AM

• benschac edited the summary of this revision. (Show Details)Apr 11 2022, 11:46 AM

• benschac added reviewers: tomek, • jacek.

Harbormaster completed remote builds in B8086: Diff 11310.Apr 11 2022, 11:52 AM

• benschac requested review of this revision.Apr 11 2022, 11:52 AM

change text color per issue and conversation with ashoat.

It's hard to verify the diff when we don't know what was agreed. It is probably described on linear - the comment says that:

Talked IRL with @ashoat, settled on var(--shades-of-white-60); for the selected text color of the chat thread list item.

But it looks like on current master the value of --thread-color-read is --thread-color-read: var(--shades-black-60). Does the value of --thread-color-read changes in one of your diffs? This diff isn't a part of a stack so it shouldn't depend on anything else.

This revision now requires changes to proceed.Apr 12 2022, 9:49 AM

update colors

ty for catching this! you're 100% right: