[web] First pass at styling `InvalidUploadModal`
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 3:26 PM.

Details

Reviewers

• jacek
tomek

Commits

rCOMM816570905507: [web] First pass at styling `InvalidUploadModal`

Summary

Started with styles borrowed from thread-settings-modal.css and made some tweaks so it looks decent.

Before:

After:

Test Plan

Dragged SVG file into message list
Confirmed that the modal looked as expected

Diff Detail

Repository

rCOMM Comm

Branch

landapril13 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 11 2022, 3:26 PM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 11 2022, 3:26 PM

atul edited the summary of this revision. (Show Details)Apr 11 2022, 3:27 PM

Harbormaster completed remote builds in B8099: Diff 11326.Apr 11 2022, 3:31 PM

atul requested review of this revision.Apr 11 2022, 3:31 PM

It looks like it might be beneficial to create a new component (e.g. Prompt?) that is a modal with title, text, and button(s). It could be used in a couple of places.

Edit: looking at the next diffs it seems like a really good idea to have something like that. By doing that we will greatly reduce duplication.

This revision is now accepted and ready to land.Apr 13 2022, 4:20 AM

It looks like it might be beneficial to create a new component (e.g. Prompt?) that is a modal with title, text, and button(s). It could be used in a couple of places.

Yeah I agree, that would reduce a lot of the duplication here... and reduce the amount of work the next time we want to create one of these prompts/alerts.

Created a Linear issue to track that work: https://linear.app/comm/issue/ENG-1003/[web]-introduce-prompt-component

rebase before landing

Harbormaster completed remote builds in B8162: Diff 11425.Apr 13 2022, 8:54 AM

Closed by commit rCOMM816570905507: [web] First pass at styling `InvalidUploadModal` (authored by atul). · Explain WhyApr 13 2022, 8:54 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM816570905507: [web] First pass at styling `InvalidUploadModal`.