[services] Tunnelbroker - Refactor time types
ClosedPublic
Actions

Authored by • karol on Apr 12 2022, 1:39 AM.

Details

Reviewers

• max
tomek

Commits

rCOMM26db5a830665: [services] Tunnelbroker - Refactor time types

Summary

We want to change long long to int64_t to be sure about the size of variables(long basically might be compiler-dependent).

https://linear.app/comm/issue/ENG-584/refactor-time-types-in-c

Test Plan

cd services
yarn run-tunnelbroker-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 12 2022, 1:39 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 12 2022, 1:39 AM

• karol edited the summary of this revision. (Show Details)Apr 12 2022, 1:40 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, tomek.

Harbormaster completed remote builds in B8111: Diff 11338.Apr 12 2022, 1:43 AM

• karol requested review of this revision.Apr 12 2022, 1:43 AM

• max accepted this revision.Apr 12 2022, 3:46 AM

This revision is now accepted and ready to land.Apr 12 2022, 3:46 AM

Not sure why it is ready to land, I thought Tomek's approval was needed for this.

• karol added 1 blocking reviewer(s): tomek.Apr 12 2022, 5:42 AM

This revision now requires review to proceed.Apr 12 2022, 5:42 AM

In D3711#101977, @karol-bisztyga wrote:

Not sure why it is ready to land, I thought Tomek's approval was needed for this.

We don't have it configured on Phabricator. It would be really hard to define rules that add just one of the four blocking reviewers (we can't add all of them, as each of the blocking reviewers need to accept on Phabricator). So the current approach is to assign a blocking reviewer by either diff author or some other reviewer, when a diff gets accepted.

This revision is now accepted and ready to land.Apr 12 2022, 9:36 AM

Closed by commit rCOMM26db5a830665: [services] Tunnelbroker - Refactor time types (authored by • karol). · Explain WhyApr 13 2022, 4:00 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM26db5a830665: [services] Tunnelbroker - Refactor time types.