[web] Remove `newThreadPasswordInput` from `thread-settings-modal`
ClosedPublic
Actions

Authored by atul on Apr 13 2022, 11:15 AM.

Details

Reviewers

• jacek
tomek

Commits

rCOMMbf46c9287552: [web] Remove `newThreadPasswordInput` from `thread-settings-modal`

Summary

As part of cleaning up ThreadSettingsModal found that newThreadPasswordInput wasn't being used anywhere... so removed it.

Test Plan

Searched file (and rest of codebase) for newThreadPasswordInput and newThreadPasswordInputRef and found no usages.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 13 2022, 11:15 AM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 13 2022, 11:15 AM

Harbormaster completed remote builds in B8176: Diff 11445.Apr 13 2022, 11:20 AM

atul requested review of this revision.Apr 13 2022, 11:20 AM

tomek accepted this revision.Apr 14 2022, 1:55 AM

This revision is now accepted and ready to land.Apr 14 2022, 1:55 AM

rebase before landing

Harbormaster completed remote builds in B8215: Diff 11486.Apr 14 2022, 12:37 PM

rebase before landing (again)

Harbormaster failed remote builds in B8216: Diff 11487!Apr 14 2022, 12:48 PM

Harbormaster completed remote builds in B8216: Diff 11487.Apr 14 2022, 1:31 PM

Closed by commit rCOMMbf46c9287552: [web] Remove `newThreadPasswordInput` from `thread-settings-modal` (authored by atul). · Explain WhyApr 14 2022, 1:33 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbf46c9287552: [web] Remove `newThreadPasswordInput` from `thread-settings-modal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-modal.react.js

5 lines

Diff 11445

View Options

web/modals/threads/thread-settings-modal.react.js

[web] Remove `newThreadPasswordInput` from `thread-settings-modal`ClosedPublicActions