arrows on safari are visually broken. add transparent color.
https://linear.app/comm/issue/ENG-1005/arrows-broken-in-safari
before:
after:
Differential D3730
[web] [fix] [ENG-1005] arrows visually broken on safari • benschac on Apr 14 2022, 7:54 AM. Authored by Tags None Referenced Files
Details arrows on safari are visually broken. add transparent color. https://linear.app/comm/issue/ENG-1005/arrows-broken-in-safari before: after: go to /comm/ in safari. Make sure the arrows match chrome.
Diff Detail
Event TimelineComment Actions Do we know why this is happening? I would expect that setting the color prop to transparent would make the arrow "invisible." I'm guessing the underlying SVG has some color value hard-coded and is "visible" because the stroke or fill or whatever is set to the correct color. I think the right approach here might be looking at selection.json and seeing if there are any hard-coded values for the right-angle-arrow SVG. Feel free to re-request review if I'm off-base here or missing something Comment Actions https://linear.app/comm/issue/ENG-1005/arrows-broken-in-safari -- yeah the commit which caused the problem is in the link of the issue. Yeah, the color is set to currentColor which is changed in that commit. I'm just setting the color which was transparent before to transparent. Comment Actions
I searched through the commit for color and SWMansionIcon and currentColor and transparent and couldn't find any relevant changes? Could you point out file/line number, I'm probably missing something Comment Actions Looks like clearing attrs (selection.js:939) for the right-angle-arrow icon fixes the issue: Before: After: Comment Actions @benschac has been struggling to figure out a solution to the SVG arrow for quite some time... at this point, would really appreciate if @atul could step in and make sure Ben is able to unblock himself ASAP. Whatever is necessary (eg. a Tuple session), let's get that done ASAP so @benschac can land a solution to this issue. (Ideally in the future @benschac can handle this stuff fully independently) To be clear, this isn't an endorsement of any of @atul's proposals/analysis above – just a reflection that this need to be unblocked ASAP, and it looks like @atul's direct involvement is necessary at a deeper level to make that happen |