Paths

Table of Contentst

Differential D3745

[web] Introduce "Add Members" button in `MembersModal`
ClosedPublic
Actions

Authored by • jacek on Apr 15 2022, 4:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 2:50 PM

	Unknown Object (File)
	Sun, Oct 27, 10:10 PM

	Unknown Object (File)
	Wed, Oct 23, 6:43 AM

	Unknown Object (File)
	Tue, Oct 22, 10:49 PM

	Unknown Object (File)
	Sun, Oct 20, 7:20 PM

	Unknown Object (File)
	Sun, Oct 20, 12:38 PM

	Unknown Object (File)
	Sat, Oct 19, 11:16 AM

	Unknown Object (File)
	Sat, Oct 19, 11:16 AM

Subscribers

Details

Reviewers

tomek
atul
• benschac

Commits

rCOMM5a5d54e9c537: [web] Introduce "Add Members" button in `MembersModal`

Summary

Introduce button in Members modal launching "AddMembrsModal". The button is displayed if user has "ADD_MEMBERS" permission.

Screenshot_Google Chrome_2022-04-15_140135.png (809×482 px, 30 KB)

Test Plan

Launch members modal from thread action menu in some community thread. The button should be displayed and launching "AddMembersModal"

Diff Detail

Repository

Branch

jacek/add-members

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Apr 15 2022, 4:45 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 15 2022, 4:45 AM

• jacek edited the summary of this revision. (Show Details)Apr 15 2022, 5:02 AM

• jacek added reviewers: tomek, atul, • benschac.

Harbormaster completed remote builds in B8231: Diff 11515.Apr 15 2022, 8:31 AM

• jacek requested review of this revision.Apr 15 2022, 8:31 AM

atul accepted this revision.Apr 15 2022, 10:45 AM

atul added inline comments.

web/modals/threads/members/members-modal.react.js
89–92 ↗	(On Diff #11515)	Wonder if it would be cleaner to pull this outside of the `React.useMemo`?

This revision is now accepted and ready to land.Apr 15 2022, 10:45 AM

• jacek added inline comments.Apr 29 2022, 2:57 AM

web/modals/threads/members/members-modal.react.js
89–92 ↗	(On Diff #11515)	I missed this comment, sorry. I'm not sure if it would be cleaner, but we agreed with Tomek, that it could improve performance a bit - the memo wouldn't depend on the whole `threadInfo`. I'll move it outside.

Move canAddMembers outside the useMemo.

Harbormaster completed remote builds in B8685: Diff 12096.Apr 29 2022, 3:17 AM

Closed by commit rCOMM5a5d54e9c537: [web] Introduce "Add Members" button in `MembersModal` (authored by • jacek). · Explain WhyApr 29 2022, 3:44 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM5a5d54e9c537: [web] Introduce "Add Members" button in `MembersModal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

members-modal.css

13 lines

members-modal.react.js

47 lines

Diff 12096

web/modals/threads/members/members-modal.css

Loading...

web/modals/threads/members/members-modal.react.js

Loading...