Page MenuHomePhabricator

[services] Tunnelbroker - Test of `createdAt` field in the messageItem
ClosedPublic

Authored by max on Apr 21 2022, 7:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 9:31 PM
Unknown Object (File)
Sat, Oct 26, 7:46 AM
Unknown Object (File)
Fri, Oct 25, 12:02 AM
Unknown Object (File)
Fri, Oct 25, 12:02 AM
Unknown Object (File)
Fri, Oct 25, 12:02 AM
Unknown Object (File)
Fri, Oct 25, 12:02 AM
Unknown Object (File)
Fri, Oct 25, 12:02 AM
Unknown Object (File)
Oct 7 2024, 11:29 PM

Details

Summary

The new field createdAt was added at D3805. Adding the test for it to the messageItem fields testings.

Test Plan

Run yarn test-tunnelbroker-service all tests are run and succeed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max added reviewers: karol, tomek.

I think this little test addition would be enough not to flood the tests for each field and spend too much on it.

max retitled this revision from [services] Tunnelbroker - Append test of `createdAt` field in the messageItem to [services] Tunnelbroker - Test of `createdAt` field in the messageItem.Apr 21 2022, 8:02 AM
tomek requested changes to this revision.Apr 21 2022, 8:41 AM
tomek added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
56 ↗(On Diff #11727)

Can we get a timestamp at the beginning of this test and compare it to getCreatedAt instead of having a hardcoded value?

This revision now requires changes to proceed.Apr 21 2022, 8:41 AM

Changed equal of the createdAt to the generated timestamp.

max added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
56 ↗(On Diff #11727)

Can we get a timestamp at the beginning of this test and compare it to getCreatedAt instead of having a hardcoded value?

That makes sense to me, thanks. Changed it.

tomek added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
24 ↗(On Diff #11773)

This change shouldn't be a part of this diff. Why it was introduced?

56 ↗(On Diff #11773)

We can also keep the second condition

This revision is now accepted and ready to land.Apr 25 2022, 2:23 AM
max marked an inline comment as done.

Rebased on master, fixes on comments.

max added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
24 ↗(On Diff #11773)

This change shouldn't be a part of this diff. Why it was introduced?

Removed it. Thanks.

56 ↗(On Diff #11773)

We can also keep the second condition

Let's keep them both. Added them.