Removing the expire from the constructor because we will fulfill it at the DB insertion phase at DatabaseManager's insert.
Constant with the max message TTL in the database was added.
Details
Details
Run yarn test-tunnelbroker-service all tests are run and succeed.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- fix-messageitem-expire
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/tunnelbroker/src/Constants.h | ||
|---|---|---|
| 51 ↗ | (On Diff #11729) | This is a bit unclear to me |
| services/tunnelbroker/src/Constants.h | ||
|---|---|---|
| 51 ↗ | (On Diff #11729) | Agree. What is the meaning of 10 at the end? It also looks like we were using milliseconds for other TTLs. So shouldn't this be 300 * 24 * 60 * 60 * 1000? (we also need to verify if it works correctly, as the value can't fit in 32 bits). |
Comment Actions
Rebase on master. Multiplication of the MESSAGE_RECORD_TTL was changed due to the comment.
| services/tunnelbroker/src/Constants.h | ||
|---|---|---|
| 51 ↗ | (On Diff #11729) |
That change makes sense to me. I've updated with these changes. |
| 51 ↗ | (On Diff #11729) |
This TTL is used in the DynamoDB TTL index to clear the old messages by the database itself. |
| services/tunnelbroker/src/Constants.h | ||
|---|---|---|
| 30 ↗ | (On Diff #12219) | This description comment was updated to be more clear, because we added one more TTL and we need to distinguish them between each other. |