Page MenuHomePhabricator
Differential D3815

[native] [chore] [ENG-1032] make props and state covariant
AbandonedPublicDraft
Actions

Authored by • benschac on Apr 22 2022, 6:52 AM.
Tags
None
Referenced Files
F3382922: D3815.diff
Thu, Nov 28, 12:44 PM
Unknown Object (File)
Tue, Nov 5, 5:09 AM
Unknown Object (File)
Tue, Nov 5, 5:09 AM
Unknown Object (File)
Tue, Nov 5, 5:07 AM
Unknown Object (File)
Tue, Oct 29, 5:35 PM
Unknown Object (File)
Oct 25 2024, 12:05 AM
Unknown Object (File)
Oct 25 2024, 12:05 AM
Unknown Object (File)
Oct 25 2024, 12:05 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
atul
tomek
• jacek
• abosh
Summary

small chore, add covariant types to native error boundary

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
benjamin/eng-813-add-error-boundarieswd
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Apr 22 2022, 6:52 AM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptApr 22 2022, 6:52 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 22 2022, 6:56 AM
Harbormaster failed remote builds in B8462: Diff 11801!
• benschac retitled this revision from [native] [chore] [] make props and state covariant to [native] [chore] [ENG-1032] make props and state covariant.Apr 22 2022, 8:09 AM
• benschac edited the summary of this revision. (Show Details)

Going to merge this change with D3816 since it's covering the entire web and native dirs and does the same thing.

• benschac mentioned this in D3816: [web,native] [chore] [ENG-1032] add covariant declarations to props that were missing.Apr 22 2022, 8:12 AM
• benschac abandoned this revision.Apr 22 2022, 8:12 AM

closing this diff in favor of D3816

Revision Contents
Changeset List

PathSize
native/
4 lines

Diff 11801

View Options

native/error-boundary.react.js

Loading...