Page MenuHomePhabricator
Differential D3818

[Identity] Reorder Dockerfile contents
ClosedPublic
Actions

Authored by varun on Apr 22 2022, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 10:44 AM
Unknown Object (File)
Tue, Apr 8, 7:07 PM
Unknown Object (File)
Tue, Apr 8, 5:37 PM
Unknown Object (File)
Tue, Apr 8, 9:01 AM
Unknown Object (File)
Tue, Apr 8, 8:25 AM
Unknown Object (File)
Sun, Apr 6, 11:29 PM
Unknown Object (File)
Sun, Apr 6, 11:25 PM
Unknown Object (File)
Sun, Apr 6, 11:20 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• jim
• karol
tomek

Details

Reviewers
• jim
atul
Commits
rCOMMe6e82dcdb360: [Identity] Reorder Dockerfile contents
Summary

Addressing a comment from @jimpo in a previous diff. We should install rustfmt immediately after setting the user.

Test Plan

Build the docker image

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
6 lines

Diff 11817

View Options

services/identity/Dockerfile

Show First 20 Lines • Show All 368 Lines • ▼ Show 20 Lines currentUser: {
subscription: { subscription: {
pushNotifs: false, pushNotifs: false,
home: false, home: false,
}, },
unread: false, unread: false,
}, },
repliesCount: 0, repliesCount: 0,
sourceMessageID, sourceMessageID,
pinnedCount: 0,
}; };
const userInfos = {}; const userInfos = {};
for (const member of members) { for (const member of members) {
const { id, username } = member; const { id, username } = member;
userInfos[id] = { id, username }; userInfos[id] = { id, username };
} }
▲ Show 20 Lines • Show All 307 Lines • ▼ Show 20 Lines
type RawThreadInfoOptions = { type RawThreadInfoOptions = {
+includeVisibilityRules?: ?boolean, +includeVisibilityRules?: ?boolean,
+filterMemberList?: ?boolean, +filterMemberList?: ?boolean,
+hideThreadStructure?: ?boolean, +hideThreadStructure?: ?boolean,
+shimThreadTypes?: ?{ +shimThreadTypes?: ?{
+[inType: ThreadType]: ThreadType, +[inType: ThreadType]: ThreadType,
}, },
+filterDetailedThreadEditPermissions?: boolean, +filterDetailedThreadEditPermissions?: boolean,
+excludePinnedCount?: boolean,
}; };
function rawThreadInfoFromServerThreadInfo( function rawThreadInfoFromServerThreadInfo(
serverThreadInfo: ServerThreadInfo, serverThreadInfo: ServerThreadInfo,
viewerID: string, viewerID: string,
options?: RawThreadInfoOptions, options?: RawThreadInfoOptions,
): ?RawThreadInfo { ): ?RawThreadInfo {
const includeVisibilityRules = options?.includeVisibilityRules; const includeVisibilityRules = options?.includeVisibilityRules;
const filterMemberList = options?.filterMemberList; const filterMemberList = options?.filterMemberList;
const hideThreadStructure = options?.hideThreadStructure; const hideThreadStructure = options?.hideThreadStructure;
const shimThreadTypes = options?.shimThreadTypes; const shimThreadTypes = options?.shimThreadTypes;
const filterDetailedThreadEditPermissions = const filterDetailedThreadEditPermissions =
options?.filterDetailedThreadEditPermissions; options?.filterDetailedThreadEditPermissions;
const excludePinnedCount = options?.excludePinnedCount;
const members = []; const members = [];
let currentUser; let currentUser;
for (const serverMember of serverThreadInfo.members) { for (const serverMember of serverThreadInfo.members) {
if ( if (
filterMemberList && filterMemberList &&
serverMember.id !== viewerID && serverMember.id !== viewerID &&
!serverMember.role && !serverMember.role &&
▲ Show 20 Lines • Show All 87 Lines • ▼ Show 20 Lines if (serverThreadInfo.avatar) {
rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar }; rawThreadInfo = { ...rawThreadInfo, avatar: serverThreadInfo.avatar };
} }
if (includeVisibilityRules) { if (includeVisibilityRules) {
return { return {
...rawThreadInfo, ...rawThreadInfo,
visibilityRules: rawThreadInfo.type, visibilityRules: rawThreadInfo.type,
}; };
} }
if (!excludePinnedCount) {
return {
...rawThreadInfo,
pinnedCount: serverThreadInfo.pinnedCount,
};
}
return rawThreadInfo; return rawThreadInfo;
} }
function filterThreadEditDetailedPermissions( function filterThreadEditDetailedPermissions(
permissions: ThreadPermissionsInfo, permissions: ThreadPermissionsInfo,
shouldFilter: ?boolean, shouldFilter: ?boolean,
): ThreadPermissionsInfo { ): ThreadPermissionsInfo {
if (!shouldFilter) { if (!shouldFilter) {
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 Lines let threadInfo: ThreadInfo = {
roles: rawThreadInfo.roles, roles: rawThreadInfo.roles,
currentUser: getCurrentUser(rawThreadInfo, viewerID, userInfos), currentUser: getCurrentUser(rawThreadInfo, viewerID, userInfos),
repliesCount: rawThreadInfo.repliesCount, repliesCount: rawThreadInfo.repliesCount,
}; };
threadInfo = { threadInfo = {
...threadInfo, ...threadInfo,
uiName: threadUIName(threadInfo), uiName: threadUIName(threadInfo),
}; };
const { sourceMessageID, avatar } = rawThreadInfo; const { sourceMessageID, avatar, pinnedCount } = rawThreadInfo;
if (sourceMessageID) { if (sourceMessageID) {
threadInfo = { ...threadInfo, sourceMessageID }; threadInfo = { ...threadInfo, sourceMessageID };
} }
if (avatar) { if (avatar) {
threadInfo = { ...threadInfo, avatar }; threadInfo = { ...threadInfo, avatar };
} else if ( } else if (
rawThreadInfo.type === threadTypes.PERSONAL || rawThreadInfo.type === threadTypes.PERSONAL ||
rawThreadInfo.type === threadTypes.PRIVATE rawThreadInfo.type === threadTypes.PRIVATE
) { ) {
threadInfo = { threadInfo = {
...threadInfo, ...threadInfo,
avatar: getUserAvatarForThread(rawThreadInfo, viewerID, userInfos), avatar: getUserAvatarForThread(rawThreadInfo, viewerID, userInfos),
}; };
} }
if (pinnedCount) {
threadInfo = { ...threadInfo, pinnedCount };
}
return threadInfo; return threadInfo;
} }
function getCurrentUser( function getCurrentUser(
threadInfo: RawThreadInfo | ThreadInfo, threadInfo: RawThreadInfo | ThreadInfo,
viewerID: ?string, viewerID: ?string,
userInfos: UserInfos, userInfos: UserInfos,
): ThreadCurrentUserInfo { ): ThreadCurrentUserInfo {
▲ Show 20 Lines • Show All 712 Lines • Show Last 20 Lines