[services] Tunnelbroker - Fix warnings during the AmqpManager build
ClosedPublic
Actions

Authored by • max on Apr 25 2022, 3:04 AM.

Details

Reviewers

• karol
tomek
varun

Commits

rCOMM4d441a3945c9: [services] Tunnelbroker - Fix warnings during the AmqpManager build

Summary

Fixing small std::string conversion warnings during the build process:

AmqpManager.cpp:40:30: use of overloaded operator '=' is ambiguous (with operand types 'AMQP::AssociativeFieldProxy' (aka 'FieldProxy<AMQP::Table, basic_string<char, char_traits<char>, allocator<char>>>') and 'const size_t' (aka 'const unsigned long'))
[build]   arguments["x-message-ttl"] = AMQP_MESSAGE_TTL;

Test Plan

Run yarn run-tunnelbroker-service and successfully built the service without any warnings.

Diff Detail

Repository

rCOMM Comm

Branch

amqp-warnings-fix

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Apr 25 2022, 3:04 AM

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptApr 25 2022, 3:04 AM

• max edited the summary of this revision. (Show Details)Apr 25 2022, 3:05 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, tomek, varun.

• max edited the summary of this revision. (Show Details)Apr 25 2022, 3:08 AM

Harbormaster completed remote builds in B8493: Diff 11839.Apr 25 2022, 3:09 AM

• max requested review of this revision.Apr 25 2022, 3:09 AM

Rebased on master.

• max added a child revision: D3833: [services] Tunnelbroker - Put and get messages from database in grpc handler.Apr 25 2022, 7:20 AM

Harbormaster completed remote builds in B8506: Diff 11865.Apr 25 2022, 7:21 AM

• karol added inline comments.Apr 26 2022, 2:49 AM

services/tunnelbroker/src/Amqp/AmqpManager.cpp
63–69	where does `get()` come from?

tomek accepted this revision.Apr 26 2022, 10:26 AM

tomek added 1 blocking reviewer(s): • karol.

basically, this looks good but please respond, thanks.

This revision is now accepted and ready to land.Apr 27 2022, 11:57 PM

Removing .get() from this update.

• max marked an inline comment as done.May 2 2022, 4:53 AM

• max added inline comments.

services/tunnelbroker/src/Amqp/AmqpManager.cpp
63–69	where does `get()` come from? It's from AMQP:: Table. I've re-checked and I think it is redundant here and we can omit `get()` here. The warning was related only when set `AMQP::Table` not about get it. I've removed it as redundant. Thanks for a fast review!