Paths

Table of Contentst

-
lib/webpack/
-
webpack/
-
shared.cjs

Differential D3834

[lib] Fix ESLint errors on lib/webpack/shared.cjs
ClosedPublic
Actions

Authored by ashoat on Apr 25 2022, 8:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 19, 5:31 AM

	Unknown Object (File)
	Tue, Mar 4, 9:26 PM

	Unknown Object (File)
	Feb 15 2025, 1:49 AM

	Unknown Object (File)
	Feb 3 2025, 7:29 AM

	Unknown Object (File)
	Jan 30 2025, 5:02 PM

	Unknown Object (File)
	Jan 30 2025, 5:01 PM

	Unknown Object (File)
	Jan 30 2025, 8:57 AM

	Unknown Object (File)
	Jan 6 2025, 8:23 PM

Subscribers

Details

Reviewers

Commits

rCOMM3ad88fafa1ae: [lib] Fix ESLint errors on lib/webpack/shared.cjs

Summary

In the parent diff we make ESLint work with .cjs files. This diff corrects the resultant errors.

Test Plan

eslint lib/webpack/shared.cjs

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 25 2022, 8:48 AM

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptApr 25 2022, 8:48 AM

ashoat added a parent revision: D3761: [lib,web,native,landing] [chore] update eslint config to correctly handle cjs files.Apr 25 2022, 8:49 AM

ashoat added a child revision: D3835: Enable lint-staged for cjs files.Apr 25 2022, 8:50 AM

Harbormaster completed remote builds in B8511: Diff 11870.Apr 25 2022, 8:54 AM

ashoat requested review of this revision.Apr 25 2022, 8:54 AM

Makes sense, ran lint-staged locally and it's working as expected on my end.

This revision is now accepted and ready to land.Apr 25 2022, 10:46 AM

Closed by commit rCOMM3ad88fafa1ae: [lib] Fix ESLint errors on lib/webpack/shared.cjs (authored by ashoat). · Explain WhyApr 25 2022, 5:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3ad88fafa1ae: [lib] Fix ESLint errors on lib/webpack/shared.cjs.

Revision Contents
Changeset List

Path

Size

lib/

webpack/

7 lines

Diff 11894

lib/webpack/shared.cjs

Loading...