Paths

Table of Contentst

-
lib/webpack/
-
webpack/
-
shared.cjs

shared.cjs
ClosedPublic
Actions

Authored by ashoat on Apr 25 2022, 8:48 AM.

Tags

None

Referenced Files

	F5906773: D3834.id11894.diff
	Thu, Apr 17, 2:20 PM

	F5894156: D3834.id.diff
	Thu, Apr 17, 10:06 AM

	F5891859: D3834.id11870.diff
	Thu, Apr 17, 7:49 AM

	Unknown Object (File)
	Wed, Apr 16, 8:05 AM

	Unknown Object (File)
	Fri, Apr 11, 3:23 AM

	Unknown Object (File)
	Fri, Mar 28, 9:13 AM

	Unknown Object (File)
	Thu, Mar 27, 6:20 AM

	Unknown Object (File)
	Mon, Mar 24, 12:47 AM

Subscribers

Details

Reviewers

• benschac

Commits

rCOMM3ad88fafa1ae: [lib] Fix ESLint errors on lib/webpack/shared.cjs

Summary

In the parent diff we make ESLint work with .cjs files. This diff corrects the resultant errors.

Test Plan

eslint lib/webpack/shared.cjs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 25 2022, 8:48 AM

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptApr 25 2022, 8:48 AM

ashoat added a parent revision: D3761: [lib,web,native,landing] [chore] update eslint config to correctly handle cjs files.Apr 25 2022, 8:49 AM

ashoat added a child revision: D3835: Enable lint-staged for cjs files.Apr 25 2022, 8:50 AM

Harbormaster completed remote builds in B8511: Diff 11870.Apr 25 2022, 8:54 AM

ashoat requested review of this revision.Apr 25 2022, 8:54 AM

Makes sense, ran lint-staged locally and it's working as expected on my end.

This revision is now accepted and ready to land.Apr 25 2022, 10:46 AM

Closed by commit rCOMM3ad88fafa1ae: [lib] Fix ESLint errors on lib/webpack/shared.cjs (authored by ashoat). · Explain WhyApr 25 2022, 5:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3ad88fafa1ae: [lib] Fix ESLint errors on lib/webpack/shared.cjs.

Revision Contents
Changeset List

Path

Size

lib/

webpack/

shared.cjs

7 lines

Diff 11894

View Options

[lib] Fix ESLint errors on lib/webpack/shared.cjsClosedPublicActions