[web, keyserver] [fix] [ENG-1022] add arrows much closer to spec [squashed diff into another stack]
AbandonedPublic
Actions

Authored by • benschac on Apr 25 2022, 11:57 AM.

Details

Reviewers

atul
tomek

Summary

This is a diff to show what's going on when I try to just add an svg as an image. Attaching a screenshot. But, it's looking like the extended arrow isn't the same width, arrow thickness, or shape as the original arrow. I tried updating both the svg view box and height + width properties without much luck.

Image 2022-04-25 at 2.52.19 PM.jpg (448×940 px, 34 KB)

Update 4/26/2022

Made some progress here, and it's pretty close to the design.

I need to adjust the size of the chat thread item in another diff. Additonally, the arrows need to be cut down by like 2-3px.

Added a linear task: https://linear.app/comm/issue/ENG-1053/remove-2px-from-long-arrows so we don't forget.

Image 2022-04-26 at 5.31.48 PM.jpg (548×888 px, 42 KB)

Test Plan

N/A, this diff is just to document and show the team what the "use an image" html element path looks like.

Diff Detail

Repository

rCOMM Comm

Branch

benjamin/eng-1022-update-arrows-in-sidebar

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 25 2022, 11:57 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 25 2022, 11:57 AM

• benschac edited the summary of this revision. (Show Details)Apr 25 2022, 11:58 AM

• benschac added a parent revision: D3839: [web] [remove] [ENG-1022] add long arrow and implement in sidebar.

Harbormaster completed remote builds in B8528: Diff 11887.Apr 25 2022, 12:01 PM

• benschac requested review of this revision.Apr 25 2022, 12:01 PM

fixup arrows design

Harbormaster completed remote builds in B8584: Diff 11965.Apr 26 2022, 2:26 PM

• benschac edited the summary of this revision. (Show Details)Apr 26 2022, 2:33 PM

• benschac retitled this revision from [web, keyserver] [fix] [ENG-1022] add svg images to sidebar to try and fix arrow issue to [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec.Apr 26 2022, 2:38 PM

• benschac edited the summary of this revision. (Show Details)

I need to adjust the size of the chat thread item in another diff.

Are you sure we should do that?

keyserver/images/long_arrow.svg
1 ↗	(On Diff #11965)	Why do we define xml version in one file and not in the other?
web/chat/sidebar-item.react.js
33 ↗	(On Diff #11965)	I don't think this will be displayed, but if `alt` is visible, I think it would be better to be e.g. `>` or `->` instead of this long text

This revision now requires changes to proceed.Apr 27 2022, 6:25 AM

squashed this commit into D3839. Closing this diff in favor of D3839.

In D3841#107354, @palys-swm wrote:

I need to adjust the size of the chat thread item in another diff.

Are you sure we should do that?

Ported and answered these questions in D3839

• benschac retitled this revision from [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec to [web, keyserver] [fix] [ENG-1022] add arrows much closer to spec [squashed diff into another stack].May 2 2022, 9:39 AM