[keyserver] Add rsync to Dockerfile
ClosedPublic
Actions

Authored by ashoat on Apr 25 2022, 7:47 PM.

Details

Reviewers

tomek
• jim

Commits

rCOMM79cd758bbef8: [keyserver] Add rsync to Dockerfile

Summary

We use rsync here, so we need to make sure it's in our Dockerfile.

This diff also organizes the Dockerfile into sections. Figured that change was too small to require its own diff.

Depends on D3847

Test Plan

tested that yarn rsync worked inside the Docker image

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 25 2022, 7:47 PM

Herald added subscribers: • abosh, • karol, atul, • adrian. · View Herald TranscriptApr 25 2022, 7:47 PM

ashoat added a child revision: D3849: [keyserver] Add nvm to Dockerfile.Apr 25 2022, 7:48 PM

Harbormaster completed remote builds in B8536: Diff 11898.Apr 25 2022, 7:55 PM

ashoat requested review of this revision.Apr 25 2022, 7:55 PM

tomek accepted this revision.Apr 26 2022, 9:41 AM

tomek added inline comments.

keyserver/Dockerfile
20	Maybe I'm missing something, but it looks like `cleaninstall` is run after copying

This revision is now accepted and ready to land.Apr 26 2022, 9:41 AM

ashoat added inline comments.Apr 27 2022, 10:59 AM

keyserver/Dockerfile
20	It will be more obvious later. We are only copying in a small list of files here – the rest of the files get copied in later

Closed by commit rCOMM79cd758bbef8: [keyserver] Add rsync to Dockerfile (authored by ashoat). · Explain WhyApr 27 2022, 11:40 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM79cd758bbef8: [keyserver] Add rsync to Dockerfile.

Revision Contents
Changeset List

Path

Size

keyserver/

Dockerfile

14 lines

Diff 11898

View Options

[keyserver] Add rsync to DockerfileClosedPublicActions