Downstream dependencies have issues surfaced by yarn audit
Checked the release notes: https://github.com/react-native-svg/react-native-svg/releases and didn't find any breaking changes
Depends on D3855
Details
Details
CI
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
- Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future
- Can you also test wherever we use react-native-svg to make sure it still works as expected?
Comment Actions
Can you also test wherever we use react-native-svg to make sure it still works as expected?
Yeah, we only use it to display the "background" tab illustration. I'll check it before landing.
Comment Actions
Good thing I didn't land it before testing the "background illustration" SVG.
I'm on my old MacBook Air and it looks like my ruby environment set up was out-of-date. As a result pod install failed silently and so the Podfile.lock file never updated.
Fixed the ruby environment, ensured that pod install ran correctly, ensured that Podfile.lock changed as expected, and made sure that the "background illustration" SVG looks as expected on iOS:
