Page MenuHomePhabricator

[yarn] Bump `clang-format` to `1.7.0`
ClosedPublic

Authored by atul on Apr 27 2022, 8:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 1:36 AM
Unknown Object (File)
Wed, Nov 13, 10:44 AM
Unknown Object (File)
Wed, Nov 13, 10:44 AM
Unknown Object (File)
Sun, Nov 10, 12:51 AM
Unknown Object (File)
Fri, Nov 8, 10:05 AM
Unknown Object (File)
Fri, Nov 8, 10:04 AM
Unknown Object (File)
Oct 9 2024, 8:10 PM
Unknown Object (File)
Oct 9 2024, 8:10 PM

Details

Summary

Downstream dependencies have issues surfaced by yarn audit

The repo doesn't have release notes (that I could find), but looking at the commits since 1.5.0 they're all bumping deps and messing with CI


Depends on D3858

Test Plan

CI

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Apr 27 2022, 8:19 AM

Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future

At some point in the future we should move this to Nix

This revision is now accepted and ready to land.Apr 27 2022, 2:32 PM

Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future

Will do

At some point in the future we should move this to Nix

As in include clang-format binary directly instead of sourcing from npm package?

In D3859#108122, @atul wrote:

At some point in the future we should move this to Nix

As in include clang-format binary directly instead of sourcing from npm package?

Yeah

This revision was automatically updated to reflect the committed changes.