Page MenuHomePhabricator
Differential D3859

[yarn] Bump `clang-format` to `1.7.0`
ClosedPublic
Actions

Authored by atul on Apr 27 2022, 8:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 6:08 PM
Unknown Object (File)
Mon, Mar 3, 6:30 PM
Unknown Object (File)
Sat, Mar 1, 7:35 PM
Unknown Object (File)
Sat, Mar 1, 7:34 PM
Unknown Object (File)
Thu, Feb 20, 10:07 AM
Unknown Object (File)
Feb 8 2025, 7:27 AM
Unknown Object (File)
Feb 4 2025, 5:45 AM
Unknown Object (File)
Feb 4 2025, 5:45 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
ashoat
Commits
rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0`
Summary

Downstream dependencies have issues surfaced by yarn audit

The repo doesn't have release notes (that I could find), but looking at the commits since 1.5.0 they're all bumping deps and messing with CI

Depends on D3858

Test Plan

CI

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 27 2022, 8:12 AM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 27 2022, 8:12 AM
atul updated this revision to Diff 11990.Apr 27 2022, 8:13 AM

dedupe

Harbormaster completed remote builds in B8605: Diff 11989.Apr 27 2022, 8:17 AM
atul edited the summary of this revision. (Show Details)Apr 27 2022, 8:18 AM
atul added a parent revision: D3858: [keyserver] Bump `node-schedule` to `2.1.0`.
Harbormaster completed remote builds in B8606: Diff 11990.Apr 27 2022, 8:19 AM
atul requested review of this revision.Apr 27 2022, 8:19 AM
atul added a child revision: D3861: [keyserver] Bump `geoip-lite` to `1.4.5`.Apr 27 2022, 8:32 AM
atul added a child revision: D3860: [yarn] Bump transitive dependencies of `react-native-vector-icons`.Apr 27 2022, 8:45 AM
atul removed a child revision: D3861: [keyserver] Bump `geoip-lite` to `1.4.5`.
atul added a child revision: D3861: [keyserver] Bump `geoip-lite` to `1.4.5`.Apr 27 2022, 10:15 AM
ashoat accepted this revision.Apr 27 2022, 2:32 PM

Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future

At some point in the future we should move this to Nix

This revision is now accepted and ready to land.Apr 27 2022, 2:32 PM
atul added a comment.Apr 28 2022, 12:00 PM

Please make sure to make me a blocking reviewer on diffs that affect dependencies in the future

Will do

At some point in the future we should move this to Nix

As in include clang-format binary directly instead of sourcing from npm package?

atul updated this revision to Diff 12062.Apr 28 2022, 12:05 PM

rebase before landing

ashoat added a comment.Apr 28 2022, 12:06 PM
In D3859#108122, @atul wrote:

At some point in the future we should move this to Nix

As in include clang-format binary directly instead of sourcing from npm package?

Yeah

Harbormaster completed remote builds in B8665: Diff 12062.Apr 28 2022, 12:10 PM
Closed by commit rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0` (authored by atul). · Explain WhyApr 28 2022, 12:22 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0`.

Revision Contents
Changeset List

PathSize
2 lines
23 lines

Diff 12063

View Options

package.json

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines
View Options

yarn.lock

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines