In D3859#108122, @atul wrote:

At some point in the future we should move this to Nix

As in include clang-format binary directly instead of sourcing from npm package?

Yeah

Harbormaster completed remote builds in B8665: Diff 12062.Apr 28 2022, 12:10 PM

Closed by commit rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0` (authored by atul). · Explain WhyApr 28 2022, 12:22 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM83dab868f3bb: [yarn] Bump `clang-format` to `1.7.0`.

Revision Contents
Changeset List

Path

Size

package.json

2 lines

yarn.lock

23 lines

Diff 11990

View Options

package.json

// @flow		// @flow

		import Icon from '@expo/vector-icons/FontAwesome5.js';
import { useNavigationState } from '@react-navigation/native';		import { useNavigationState } from '@react-navigation/native';
import invariant from 'invariant';		import invariant from 'invariant';
import * as React from 'react';		import * as React from 'react';
import { View } from 'react-native';		import { View, Text } from 'react-native';

import genesis from 'lib/facts/genesis.js';		import genesis from 'lib/facts/genesis.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';		import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import {		import {
userInfoSelectorForPotentialMembers,		userInfoSelectorForPotentialMembers,
userSearchIndexForPotentialMembers,		userSearchIndexForPotentialMembers,
} from 'lib/selectors/user-selectors.js';		} from 'lib/selectors/user-selectors.js';
import { getPotentialMemberItems } from 'lib/shared/search-utils.js';		import { getPotentialMemberItems } from 'lib/shared/search-utils.js';
▲ Show 20 Lines • Show All 189 Lines • ▼ Show 20 Lines	if (this.frozen) {
this.pendingListDataWithHeights = listDataWithHeights;		this.pendingListDataWithHeights = listDataWithHeights;
} else {		} else {
this.setState({ listDataWithHeights });		this.setState({ listDataWithHeights });
}		}
};		};
}		}

const unboundStyles = {		const unboundStyles = {
		pinnedCountBanner: {
		backgroundColor: 'panelForeground',
		height: 30,
		flexDirection: 'row',
		textAlign: 'center',
		justifyContent: 'center',
		alignItems: 'center',
		},
		pinnedCountText: {
		color: 'panelBackgroundLabel',
		marginRight: 5,
		},
container: {		container: {
backgroundColor: 'listBackground',		backgroundColor: 'listBackground',
flex: 1,		flex: 1,
},		},
threadContent: {		threadContent: {
flex: 1,		flex: 1,
},		},
hiddenThreadContent: {		hiddenThreadContent: {
▲ Show 20 Lines • Show All 124 Lines • ▼ Show 20 Lines	) {
const styles = useStyles(unboundStyles);		const styles = useStyles(unboundStyles);
const overlayContext = React.useContext(OverlayContext);		const overlayContext = React.useContext(OverlayContext);
const measureMessages = useHeightMeasurer();		const measureMessages = useHeightMeasurer();

const genesisThreadInfo = useSelector(		const genesisThreadInfo = useSelector(
state => threadInfoSelector(state)[genesis.id],		state => threadInfoSelector(state)[genesis.id],
);		);

		const bannerText = React.useMemo(() => {
		if (!threadInfo.pinnedCount \|\| threadInfo.pinnedCount === 0) {
		return '';
		}

		const messageNoun = threadInfo.pinnedCount === 1 ? 'message' : 'messages';
		return `${threadInfo.pinnedCount} pinned ${messageNoun}`;
		}, [threadInfo.pinnedCount]);
		atulUnsubmitted Not Done Inline Actions You don't need to use `React.useMemo(...)` here. The `useMemo()` hook is helpful for maintaining referential equality so that objects will be considered "shallowly equal" (`==` in JS) and we can avoid re-renders. This is helpful for objects (including `Map()`, `Set()`, etc), arrays (which are objects), and functions (which are objects). On the other hand, `string`s in JS are considered shallowly equal if they have the same contents, so we don't have to worry about re-renders if the "content" stays the same. See below: (In like C++, which you've been working w/ recently, `std::string`s can be allocated on the heap (unlike integers, booleans, etc) which may have been part of your reasoning that shallow equality would check reference instead of contents?) atul: You don't need to use `React.useMemo(...)` here. The `useMemo()` hook is helpful for…

		const pinnedCountBanner = React.useMemo(() => {
		if (!bannerText) {
		return null;
		}

		return (
		<View style={styles.pinnedCountBanner}>
		<Text style={styles.pinnedCountText}>{bannerText}</Text>
		<Icon
		name="chevron-right"
		size={12}
		color={colors.panelBackgroundLabel}
		/>
		</View>
		);
		}, [
		bannerText,
		styles.pinnedCountBanner,
		styles.pinnedCountText,
		colors.panelBackgroundLabel,
		]);

return (		return (
<MessageListContextProvider threadInfo={threadInfo}>		<MessageListContextProvider threadInfo={threadInfo}>
		{pinnedCountBanner}
<MessageListContainer		<MessageListContainer
{...props}		{...props}
usernameInputText={usernameInputText}		usernameInputText={usernameInputText}
updateUsernameInput={updateUsernameInput}		updateUsernameInput={updateUsernameInput}
userInfoInputArray={userInfoInputArray}		userInfoInputArray={userInfoInputArray}
updateTagInput={updateTagInput}		updateTagInput={updateTagInput}
resolveToUser={resolveToUser}		resolveToUser={resolveToUser}
otherUserInfos={otherUserInfos}		otherUserInfos={otherUserInfos}
Show All 14 Lines

View Options

yarn.lock

// @flow		// @flow

		import Icon from '@expo/vector-icons/FontAwesome5.js';
import { useNavigationState } from '@react-navigation/native';		import { useNavigationState } from '@react-navigation/native';
import invariant from 'invariant';		import invariant from 'invariant';
import * as React from 'react';		import * as React from 'react';
import { View } from 'react-native';		import { View, Text } from 'react-native';

import genesis from 'lib/facts/genesis.js';		import genesis from 'lib/facts/genesis.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';		import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import {		import {
userInfoSelectorForPotentialMembers,		userInfoSelectorForPotentialMembers,
userSearchIndexForPotentialMembers,		userSearchIndexForPotentialMembers,
} from 'lib/selectors/user-selectors.js';		} from 'lib/selectors/user-selectors.js';
import { getPotentialMemberItems } from 'lib/shared/search-utils.js';		import { getPotentialMemberItems } from 'lib/shared/search-utils.js';
▲ Show 20 Lines • Show All 189 Lines • ▼ Show 20 Lines	if (this.frozen) {
this.pendingListDataWithHeights = listDataWithHeights;		this.pendingListDataWithHeights = listDataWithHeights;
} else {		} else {
this.setState({ listDataWithHeights });		this.setState({ listDataWithHeights });
}		}
};		};
}		}

const unboundStyles = {		const unboundStyles = {
		pinnedCountBanner: {
		backgroundColor: 'panelForeground',
		height: 30,
		flexDirection: 'row',
		textAlign: 'center',
		justifyContent: 'center',
		alignItems: 'center',
		},
		pinnedCountText: {
		color: 'panelBackgroundLabel',
		marginRight: 5,
		},
container: {		container: {
backgroundColor: 'listBackground',		backgroundColor: 'listBackground',
flex: 1,		flex: 1,
},		},
threadContent: {		threadContent: {
flex: 1,		flex: 1,
},		},
hiddenThreadContent: {		hiddenThreadContent: {
▲ Show 20 Lines • Show All 124 Lines • ▼ Show 20 Lines	) {
const styles = useStyles(unboundStyles);		const styles = useStyles(unboundStyles);
const overlayContext = React.useContext(OverlayContext);		const overlayContext = React.useContext(OverlayContext);
const measureMessages = useHeightMeasurer();		const measureMessages = useHeightMeasurer();

const genesisThreadInfo = useSelector(		const genesisThreadInfo = useSelector(
state => threadInfoSelector(state)[genesis.id],		state => threadInfoSelector(state)[genesis.id],
);		);

		const bannerText = React.useMemo(() => {
		if (!threadInfo.pinnedCount \|\| threadInfo.pinnedCount === 0) {
		return '';
		}

		const messageNoun = threadInfo.pinnedCount === 1 ? 'message' : 'messages';
		return `${threadInfo.pinnedCount} pinned ${messageNoun}`;
		}, [threadInfo.pinnedCount]);
		atulUnsubmitted Not Done Inline Actions You don't need to use `React.useMemo(...)` here. The `useMemo()` hook is helpful for maintaining referential equality so that objects will be considered "shallowly equal" (`==` in JS) and we can avoid re-renders. This is helpful for objects (including `Map()`, `Set()`, etc), arrays (which are objects), and functions (which are objects). On the other hand, `string`s in JS are considered shallowly equal if they have the same contents, so we don't have to worry about re-renders if the "content" stays the same. See below: (In like C++, which you've been working w/ recently, `std::string`s can be allocated on the heap (unlike integers, booleans, etc) which may have been part of your reasoning that shallow equality would check reference instead of contents?) atul: You don't need to use `React.useMemo(...)` here. The `useMemo()` hook is helpful for…

		const pinnedCountBanner = React.useMemo(() => {
		if (!bannerText) {
		return null;
		}

		return (
		<View style={styles.pinnedCountBanner}>
		<Text style={styles.pinnedCountText}>{bannerText}</Text>
		<Icon
		name="chevron-right"
		size={12}
		color={colors.panelBackgroundLabel}
		/>
		</View>
		);
		}, [
		bannerText,
		styles.pinnedCountBanner,
		styles.pinnedCountText,
		colors.panelBackgroundLabel,
		]);

return (		return (
<MessageListContextProvider threadInfo={threadInfo}>		<MessageListContextProvider threadInfo={threadInfo}>
		{pinnedCountBanner}
<MessageListContainer		<MessageListContainer
{...props}		{...props}
usernameInputText={usernameInputText}		usernameInputText={usernameInputText}
updateUsernameInput={updateUsernameInput}		updateUsernameInput={updateUsernameInput}
userInfoInputArray={userInfoInputArray}		userInfoInputArray={userInfoInputArray}
updateTagInput={updateTagInput}		updateTagInput={updateTagInput}
resolveToUser={resolveToUser}		resolveToUser={resolveToUser}
otherUserInfos={otherUserInfos}		otherUserInfos={otherUserInfos}
Show All 14 Lines

[yarn] Bump `clang-format` to `1.7.0`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11990

package.json

yarn.lock

[yarn] Bump `clang-format` to `1.7.0`
ClosedPublic
Actions

Revision Contents
Changeset List