Page MenuHomePhabricator
Differential D3875

[web] Introduce close button in `Label` component
ClosedPublic
Actions

Authored by • jacek on Apr 29 2022, 4:46 AM.
Tags
None
Referenced Files
F5307175: D3875.id12323.diff
Tue, Apr 8, 5:39 AM
Unknown Object (File)
Mon, Apr 7, 5:08 AM
Unknown Object (File)
Mon, Apr 7, 5:03 AM
Unknown Object (File)
Mon, Apr 7, 5:01 AM
Unknown Object (File)
Mon, Apr 7, 4:59 AM
Unknown Object (File)
Mon, Apr 7, 4:56 AM
Unknown Object (File)
Tue, Apr 1, 12:00 PM
Unknown Object (File)
Tue, Apr 1, 11:51 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
• benschac
atul
Commits
rCOMM22df63a928fd: [web] Introduce close button in `Label` component
Summary

Introduce close action for Label component. The aim is to use in MembersModal in the list of pending users to add to the thread.

Without close action:

Screenshot_Google Chrome_2022-04-29_135216.png (47×113 px, 4 KB)

With:
Screenshot_Google Chrome_2022-04-29_135140.png (46×185 px, 5 KB)

Test Plan

Currently used Labels don't change because introduced property is optional and will be used in the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Apr 29 2022, 4:46 AM
Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptApr 29 2022, 4:46 AM
Harbormaster completed remote builds in B8693: Diff 12112.Apr 29 2022, 4:50 AM
• jacek requested review of this revision.Apr 29 2022, 4:50 AM
• jacek edited the summary of this revision. (Show Details)Apr 29 2022, 4:52 AM
• jacek added reviewers: • benschac, atul.
• jacek added a child revision: D3876: [web] Display list of pending users to add in `AddMembersModal`.Apr 29 2022, 6:11 AM
tomek accepted this revision.Apr 29 2022, 7:56 AM
This revision is now accepted and ready to land.Apr 29 2022, 7:56 AM
• jacek updated this revision to Diff 12323.May 6 2022, 1:40 AM

rebase

Harbormaster completed remote builds in B8839: Diff 12323.May 6 2022, 1:48 AM
Closed by commit rCOMM22df63a928fd: [web] Introduce close button in `Label` component (authored by • jacek). · Explain WhyMay 6 2022, 1:55 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM22df63a928fd: [web] Introduce close button in `Label` component.
• karol removed a subscriber: • karol.May 6 2022, 3:54 AM

Revision Contents
Changeset List

PathSize
web/
components/
10 lines
15 lines

Diff 12112

View Options

web/components/label.css

Loading...
View Options

web/components/label.react.js

Loading...