[web] Display list of pending users to add in `AddMembersModal`
ClosedPublic
Actions

Authored by • jacek on Apr 29 2022, 5:01 AM.

Details

Reviewers

tomek
atul
• benschac
ashoat

Commits

rCOMM4f642b558436: [web] Display list of pending users to add in `AddMembersModal`

Summary

Introduce list of pending users to add below search bar in AddMembersModal.
The diff also excludes pending users from main list in Modal, so they don't appear twice.

Test Plan

Open "Members Modal", try to add users from list, pending users appears below search bar.

Diff Detail

Repository

rCOMM Comm

Branch

jacek/pending-users-to-add

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Apr 29 2022, 5:01 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 29 2022, 5:01 AM

• jacek edited the summary of this revision. (Show Details)Apr 29 2022, 5:02 AM

Harbormaster completed remote builds in B8694: Diff 12113.Apr 29 2022, 5:06 AM

• jacek requested review of this revision.Apr 29 2022, 5:06 AM

• jacek added a parent revision: D3875: [web] Introduce close button in `Label` component.Apr 29 2022, 6:11 AM

This looks amazing! Adding @ashoat so he can take a look.

web/modals/threads/members/add-members-modal.react.js
117	In some places we use `Array.from(pendingUsersToAdd)` and here we use spread operator. It doesn't matter that much, but it might be a nice idea to be consistent
130	Have you considered using a callback here?

• jacek added inline comments.Apr 29 2022, 9:58 AM

web/modals/threads/members/add-members-modal.react.js
117	You're right. In many other places, I used `Array.from` when converting set to an array. I'll replace it to be consistent
130	Yes, I was considering it, but I concluded it's not necessary here, as it's all inside the `useMemo`.