Page MenuHomePhabricator
Differential D3880

[services] Tunnelbroker - Switch to milliseconds at `createdAt` in messages
ClosedPublic
Actions

Authored by • max on May 2 2022, 5:46 AM.
Tags
None
Referenced Files
F3687540: D3880.id12168.diff
Tue, Jan 7, 1:02 AM
F3687539: D3880.id12167.diff
Tue, Jan 7, 1:02 AM
F3687538: D3880.id12126.diff
Tue, Jan 7, 1:02 AM
F3687527: D3880.id.diff
Tue, Jan 7, 1:02 AM
F3687483: D3880.diff
Tue, Jan 7, 12:51 AM
Unknown Object (File)
Sat, Jan 4, 8:41 PM
Unknown Object (File)
Sat, Jan 4, 7:44 PM
Unknown Object (File)
Sat, Jan 4, 4:20 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
varun
ashoat
Commits
rCOMM75027b843402: [services] Tunnelbroker - Switch to milliseconds at `createdAt` in messages
Summary

Switch to milliseconds from unixtime seconds for the createdAt field on Tunnelbroker database message item related to the
ENG-1027 comment.

Using the tools::getCurrentTimestamp() to get the milliseconds since epoch.

Related task: ENG-1045

Test Plan

Run yarn test-tunnelbroker-service to build and run the tests.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.May 2 2022, 5:46 AM
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 2 2022, 5:46 AM
• max edited the summary of this revision. (Show Details)May 2 2022, 5:48 AM
• max added reviewers: • karol, tomek, varun.
• max edited the summary of this revision. (Show Details)May 2 2022, 5:52 AM
Harbormaster completed remote builds in B8705: Diff 12126.May 2 2022, 5:52 AM
• max requested review of this revision.May 2 2022, 5:52 AM
• max added a child revision: D3881: [services] Tunnelbroker - Fix `DatabaseManagerTest.cpp` build error on non-closed brackets.May 2 2022, 6:09 AM
ashoat accepted this revision.May 2 2022, 6:38 AM
ashoat removed 1 blocking reviewer(s): tomek.

@palys-swm is out on vacation this week

This revision is now accepted and ready to land.May 2 2022, 6:38 AM
• max updated this revision to Diff 12167.May 3 2022, 7:07 AM

Rebase on master.

Harbormaster completed remote builds in B8735: Diff 12167.May 3 2022, 7:12 AM
Closed by commit rCOMM75027b843402: [services] Tunnelbroker - Switch to milliseconds at `createdAt` in messages (authored by • max). · Explain WhyMay 3 2022, 7:14 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM75027b843402: [services] Tunnelbroker - Switch to milliseconds at `createdAt` in messages.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Database/
2 lines
test/
8 lines

Diff 12168

View Options

services/tunnelbroker/src/Database/DatabaseManager.cpp

Loading...
View Options

services/tunnelbroker/test/DatabaseManagerTest.cpp

Loading...