Page MenuHomePhabricator

[native] [fix] [ENG-1078] fix hot reload loosing state
ClosedPublic

Authored by benschac on May 3 2022, 2:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 30, 9:11 PM
Unknown Object (File)
Thu, May 30, 9:11 PM
Unknown Object (File)
Fri, May 17, 1:42 AM
Unknown Object (File)
Fri, May 10, 11:18 AM
Unknown Object (File)
Thu, May 9, 1:22 PM
Unknown Object (File)
Apr 28 2024, 7:42 PM
Unknown Object (File)
Apr 11 2024, 6:35 PM
Unknown Object (File)
Apr 11 2024, 6:35 PM

Details

Summary

fix for https://linear.app/comm/issue/ENG-1078/chat-view-loses-state-during-fast-refresh. Additionally, the reason this works is because https://reactnative.dev/docs/fast-refresh#how-it-works which is why we remove the additional exports from InlineSidebar and moved them into a new file.

If you edit a module with exports that aren't React components, Fast Refresh will re-run both that module, and the other modules importing it. So if both Button.js and Modal.js import Theme.js, editing Theme.js will update both components.

Test Plan

follow steps in issue. 1. update inline-sidebar.react in native, have the chatview (conversation) open, hot-reload should not navigate you away from the screen that you were currently on.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable