Page MenuHomePhabricator
Differential D3937

[web] Remove remnants of SquadCal "Request Access" functionality
ClosedPublic
Actions

Authored by atul on May 5 2022, 11:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 9:08 AM
Unknown Object (File)
Wed, Nov 13, 10:47 AM
Unknown Object (File)
Wed, Nov 13, 10:47 AM
Unknown Object (File)
Wed, Nov 13, 10:47 AM
Unknown Object (File)
Sun, Nov 3, 4:58 PM
Unknown Object (File)
Sun, Nov 3, 4:58 PM
Unknown Object (File)
Sun, Nov 3, 4:58 PM
Unknown Object (File)
Sun, Nov 3, 4:58 PM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
ashoat
tomek
Commits
rCOMMa6ac1619454f: [web] Remove remnants of SquadCal "Request Access" functionality
Summary

Removed the React side of this earlier, but looks like I missed the keyserver functionality. Found this change stashed in my local environment

Test Plan

Made sure our current landing page SubscriptionForm component continues to work as expected... they're two separate endpoints (subscribe_email for landing subscription form, request_access for "legacy" request access form)

Diff Detail

Repository
rCOMM Comm
Branch
land_may5 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 5 2022, 11:00 AM
Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 11:00 AM
atul edited the summary of this revision. (Show Details)May 5 2022, 11:01 AM
atul edited the test plan for this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2022, 11:04 AM
Harbormaster failed remote builds in B8827: Diff 12304!
atul updated this revision to Diff 12305.May 5 2022, 11:05 AM

include all changes

Harbormaster completed remote builds in B8827: Diff 12304.May 5 2022, 11:12 AM
Harbormaster completed remote builds in B8828: Diff 12305.May 5 2022, 11:19 AM
atul requested review of this revision.May 5 2022, 11:19 AM
ashoat accepted this revision.May 5 2022, 12:53 PM
This revision is now accepted and ready to land.May 5 2022, 12:53 PM
atul updated this revision to Diff 12312.May 5 2022, 1:05 PM

rebase before landing

Harbormaster completed remote builds in B8831: Diff 12312.May 5 2022, 1:10 PM
Closed by commit rCOMMa6ac1619454f: [web] Remove remnants of SquadCal "Request Access" functionality (authored by atul). · Explain WhyMay 5 2022, 1:49 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMa6ac1619454f: [web] Remove remnants of SquadCal "Request Access" functionality.

Revision Contents
Changeset List

PathSize
keyserver/
src/
emails/
2 lines
responders/
19 lines
lib/
actions/
14 lines
types/
7 lines

Diff 12312

View Options

keyserver/src/emails/access-request.js

Loading...
View Options

keyserver/src/endpoints.js

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/account-types.js

Loading...