[services] Fix dockerignore file
ClosedPublic
Actions

Authored by • karol on May 9 2022, 6:33 AM.

Details

Reviewers

tomek
ashoat

Commits

rCOMM96251ab0e57f: [services] Fix dockerignore file

Summary

Depends on D3967

I wanted to make this file more readable and also I added an entry for the blob service

Test Plan

Hard to come up with a certain plan here.
Services have to build, as usual, this is a build change.
To better check this, you'd have to manually log into the shell of a certain service and list files to see if the files listed in docker ignore are not copied to the container. You can add ls -l command to the CMD command in Dockerfiles

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.May 9 2022, 6:33 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 9 2022, 6:33 AM

• karol edited the summary of this revision. (Show Details)May 9 2022, 6:33 AM

• karol added a parent revision: D3967: [services] Merge .dockerignore files to the one in the root folder.

Harbormaster returned this revision to the author for changes because remote builds failed.May 9 2022, 6:34 AM

Harbormaster failed remote builds in B8923: Diff 12432!

• karol edited the summary of this revision. (Show Details)May 9 2022, 6:53 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, ashoat.

• karol edited the test plan for this revision. (Show Details)

fix build

Harbormaster completed remote builds in B8928: Diff 12437.May 9 2022, 7:07 AM

• karol requested review of this revision.May 9 2022, 7:07 AM

Looks good, although it seems like we accidentally missed services/blob/docker in the parent diff? Or was that on purpose?

.dockerignore
33 ↗	(On Diff #12437)	Do we need this newline?

This revision is now accepted and ready to land.May 9 2022, 9:30 AM

• karol added inline comments.May 10 2022, 1:20 AM

.dockerignore
33 ↗	(On Diff #12437)	no

remove redundant newline

Harbormaster completed remote builds in B8961: Diff 12471.May 10 2022, 1:43 AM

In D3968#111239, @ashoat wrote:

Looks good, although it seems like we accidentally missed services/blob/docker in the parent diff? Or was that on purpose?

I think this is answered in https://phabricator.ashoat.com/D3967#111494, the same applies for blob and backup

Closed by commit rCOMM96251ab0e57f: [services] Fix dockerignore file (authored by • karol). · Explain WhyMay 10 2022, 6:46 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM96251ab0e57f: [services] Fix dockerignore file.