Page MenuHomePhabricator

[services] Merge .dockerignore files to the one in the root folder
ClosedPublic

Authored by karol on May 9 2022, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 11:39 AM
Unknown Object (File)
Tue, Jun 25, 10:22 PM
Unknown Object (File)
Tue, Jun 25, 8:23 PM
Unknown Object (File)
Mon, Jun 24, 6:28 AM
Unknown Object (File)
Sat, Jun 22, 6:35 PM
Unknown Object (File)
Sat, Jun 22, 1:16 AM
Unknown Object (File)
Mon, Jun 17, 12:53 AM
Unknown Object (File)
Mon, Jun 17, 12:53 AM

Details

Summary

Merging docker ignore file from the backup service into the one in the root directory of the project.

Test Plan

Hard to come up with a certain plan here.
Services have to build, as usual, this is a build change.
To better check this, you'd have to manually log into the shell of a certain service and list files to see if the files listed in docker ignore are not copied to the container. You can add ls -l command to the CMD command in Dockerfiles

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 9 2022, 6:33 AM
Harbormaster failed remote builds in B8922: Diff 12431!
karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, ashoat.
ashoat requested changes to this revision.May 9 2022, 9:28 AM

Just a question

.dockerignore
25 ↗(On Diff #12435)

What's this newline for? Did you miss services/backup/docker?

This revision now requires changes to proceed.May 9 2022, 9:28 AM
.dockerignore
25 ↗(On Diff #12435)

this can be removed. I didn't put services/backup/docker here on purpose, because in D3909 I prevent copying the docker folder

This revision is now accepted and ready to land.May 10 2022, 5:44 AM

I'm going to wait until D3909 is landed before landing this one