Page MenuHomePhabricator
Differential D3986

Implement function to store SQLite database entities from raw notification string in SQLite database
ClosedPublic
Actions

Authored by marcin on May 10 2022, 2:59 AM.
Tags
None
Referenced Files
F5923588: D3986.id12541.diff
Thu, Apr 17, 11:30 PM
F5920288: D3986.id13956.diff
Thu, Apr 17, 10:26 PM
F5896683: D3986.diff
Thu, Apr 17, 11:11 AM
Unknown Object (File)
Tue, Apr 8, 5:17 PM
Unknown Object (File)
Tue, Apr 8, 8:48 AM
Unknown Object (File)
Tue, Apr 8, 8:41 AM
Unknown Object (File)
Tue, Apr 8, 8:35 AM
Unknown Object (File)
Tue, Apr 8, 8:29 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
• karol
Commits
rCOMM4274b423e54b: Implement function to store SQLite database entities from raw notification…
Summary

This diff uses function implemented in previous diff to store ntification in Sqlite database.

Test Plan

No testing plan. Future diffs will provide a code that uses those functions on iOS and Android respectively

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.May 10 2022, 2:59 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptMay 10 2022, 2:59 AM
Harbormaster completed remote builds in B8973: Diff 12483.May 10 2022, 3:19 AM
marcin requested review of this revision.May 10 2022, 3:19 AM
marcin added a child revision: D3991: introduce MessageOperationsUtilities files to XCode build system.May 10 2022, 4:34 AM
marcin added a parent revision: D3984: Implement translation of raw string from notification into SQLite database entities..
• karol accepted this revision.May 10 2022, 6:24 AM
• karol added 1 blocking reviewer(s): tomek.
tomek accepted this revision.May 11 2022, 4:57 AM
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/MessageOperationsUtilities/MessageOperationsUtilities.cpp
98 ↗(On Diff #12483)

Maybe by reference?

This revision is now accepted and ready to land.May 11 2022, 4:57 AM
marcin updated this revision to Diff 12541.May 11 2022, 6:58 AM

Rebase

Harbormaster failed remote builds in B9003: Diff 12541!May 11 2022, 7:00 AM
marcin updated this revision to Diff 12554.May 11 2022, 8:14 AM

Retrigger CI

Harbormaster completed remote builds in B9016: Diff 12554.May 11 2022, 9:03 AM
ashoat added a comment.May 11 2022, 6:15 PM

(Note that @palys-swm's comments has not been addressed yet)

marcin updated this revision to Diff 12717.May 16 2022, 4:56 AM

Pass string by reference

Harbormaster failed remote builds in B9140: Diff 12717!May 16 2022, 4:57 AM
marcin updated this revision to Diff 12729.May 16 2022, 5:15 AM

Rebase

Harbormaster failed remote builds in B9152: Diff 12729!May 16 2022, 5:16 AM
Harbormaster completed remote builds in B9152: Diff 12729.May 16 2022, 1:25 PM
marcin updated this revision to Diff 12800.May 17 2022, 2:54 AM

Rebase

Harbormaster failed remote builds in B9209: Diff 12800!May 17 2022, 2:55 AM
Harbormaster completed remote builds in B9209: Diff 12800.May 17 2022, 5:58 AM
marcin added a child revision: D4065: Implement JNI files to use MessageOperationUtilities in CommNotificationsHandler on Android.May 17 2022, 7:21 AM
marcin updated this revision to Diff 12848.May 18 2022, 2:10 AM

Rebase

Harbormaster failed remote builds in B9252: Diff 12848!May 18 2022, 2:10 AM
Harbormaster completed remote builds in B9252: Diff 12848.May 18 2022, 2:37 AM
marcin updated this revision to Diff 12866.May 18 2022, 4:09 AM

Rebase

Harbormaster failed remote builds in B9269: Diff 12866!May 18 2022, 4:09 AM
marcin updated this revision to Diff 12881.May 18 2022, 4:54 AM

Rebase

Harbormaster failed remote builds in B9281: Diff 12881!May 18 2022, 4:55 AM
Harbormaster completed remote builds in B9281: Diff 12881.May 18 2022, 5:55 AM
Harbormaster completed remote builds in B9269: Diff 12866.May 18 2022, 7:28 AM
marcin updated this revision to Diff 13002.May 23 2022, 5:42 AM

Use new method name: storeMessageInfos

Harbormaster completed remote builds in B9384: Diff 13002.May 23 2022, 5:49 AM
marcin updated this revision to Diff 13032.May 24 2022, 12:42 AM

Rebase master

Harbormaster completed remote builds in B9412: Diff 13032.May 24 2022, 1:16 AM
marcin updated this revision to Diff 13942.Jun 29 2022, 3:36 AM

Rebase and move to persistent storage utilities

Harbormaster completed remote builds in B10088: Diff 13942.Jun 29 2022, 4:20 AM
marcin updated this revision to Diff 13948.Jun 29 2022, 4:36 AM

Rebase

Harbormaster completed remote builds in B10094: Diff 13948.Jun 29 2022, 5:02 AM
Closed by commit rCOMM4274b423e54b: Implement function to store SQLite database entities from raw notification… (authored by marcin). · Explain WhyJun 29 2022, 5:22 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM4274b423e54b: Implement function to store SQLite database entities from raw notification….

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
13 lines

Diff 13956

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageOperationsUtilities.cpp

Show All 15 Lines
type CommIconProps = { type CommIconProps = {
+icon: CommIcons, +icon: CommIcons,
+size: number | string, +size: number | string,
+color?: string, +color?: string,
+title?: string, +title?: string,
+className?: string, +className?: string,
+disableFill?: boolean, +disableFill?: boolean,
+removeInlineStyle?: boolean, +removeInlineStyle?: boolean,
+style?: $Shape<CSSStyleDeclaration>, };
const iconStyle = {
stroke: 'none',
}; };
function CommIcon(props: CommIconProps): React.Node { function CommIcon(props: CommIconProps): React.Node {
return <IcomoonReact {...props} iconSet={iconSet} />; return <IcomoonReact {...props} style={iconStyle} iconSet={iconSet} />;
} }
export default CommIcon; export default CommIcon;