Page MenuHomePhabricator

[keyserver] Add `bash/source-nvm.sh` to `yarn babel-build`
ClosedPublic

Authored by atul on May 10 2022, 7:37 AM.
Tags
None
Referenced Files
F3353020: D3995.diff
Sat, Nov 23, 7:40 AM
Unknown Object (File)
Fri, Nov 15, 11:33 PM
Unknown Object (File)
Mon, Nov 11, 6:54 AM
Unknown Object (File)
Mon, Nov 11, 6:54 AM
Unknown Object (File)
Mon, Nov 11, 6:54 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Fri, Nov 8, 8:06 AM

Details

Summary

We have a step in the dev_instructions where the developer is supposed to run:

yarn babel-build
yarn rsync
yarn script dist/scripts/create-db.js

in the keyserver directory.

However, unlike when we run yarn dev in keyserver, we don't source node from nvm. That means that if the developer has an incompatible version of node installed, running yarn script dist/scripts/create-db.js may fail.

(In the future this sort of thing will be handled by nix)

Test Plan

Ran yarn babel-build after change and based on the logs (https://gist.github.com/atulsmadhugiri/208338778e507ae59001e63aef75631a), it sourced node 16.9.0 from nvm and completed successfully.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable