Page MenuHomePhabricator
Differential D4059

[docs] Remove Python 2 installation steps
ClosedPublic
Actions

Authored by atul on May 16 2022, 12:47 PM.
Tags
None
Referenced Files
F3274089: D4059.diff
Sat, Nov 16, 6:26 AM
Unknown Object (File)
Thu, Nov 14, 8:08 PM
Unknown Object (File)
Thu, Nov 14, 8:08 PM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Fri, Nov 8, 8:07 AM
Unknown Object (File)
Tue, Nov 5, 1:56 AM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
• jacek
tomek
ashoat
• benschac
Commits
rCOMM4b8c8de82fb2: [docs] Remove Python 2 installation steps
Summary

We were previously including Python2 because it was needed as part of the sqlite3 build process and Python2 was removed from macOS as of 12.3.0

However, the sqlite3 npm package has recently been updated and this issue has been resolved.

Depends on D4055

Test Plan
  1. Remove Python 2
  2. Ensure that Python 2 is uninstalled by running which python and where python (Python 3 is python3)
  3. Run yarn cleaninstall and see if it succeeds

Log output from above steps: https://gist.github.com/atulsmadhugiri/20ce9839b5b6f9fb142b02078e0f7b18#file-yarn-cleaninstall-sans-python2

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 16 2022, 12:47 PM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 16 2022, 12:47 PM
atul published this revision for review.May 16 2022, 12:47 PM
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B9177: Diff 12765.May 16 2022, 12:53 PM
ashoat accepted this revision.May 16 2022, 1:45 PM

Before landing, can you create two tasks:

  1. One to remove the Python2 requirement (and defaulting python to Python2) from Nix (assign to Jon or Varun)
  2. Another for the same thing, but for Docker (assign to me)
This revision is now accepted and ready to land.May 16 2022, 1:45 PM
atul added a comment.May 16 2022, 5:10 PM

Before landing, can you create two tasks

Yeah, will do tomorrow morning before landing

atul added a comment.May 17 2022, 7:19 AM

One to remove the Python2 requirement (and defaulting python to Python2) from Nix (assign to Jon or Varun)

https://linear.app/comm/issue/ENG-1156/remove-python2-requirement-from-nix

Another for the same thing, but for Docker (assign to me)

https://linear.app/comm/issue/ENG-1157/remove-python2-requirement-from-docker

atul updated this revision to Diff 12812.May 17 2022, 7:24 AM

rebase before landing

Harbormaster completed remote builds in B9220: Diff 12812.May 17 2022, 7:29 AM
Closed by commit rCOMM4b8c8de82fb2: [docs] Remove Python 2 installation steps (authored by atul). · Explain WhyMay 17 2022, 7:32 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM4b8c8de82fb2: [docs] Remove Python 2 installation steps.

Revision Contents
Changeset List

PathSize
docs/
10 lines

Diff 12765

View Options

docs/dev_environment.md

Loading...