Page MenuHomePhabricator

Introduce and run clang-format updated to newer version
ClosedPublic

Authored by marcin on May 17 2022, 6:10 AM.
Tags
None
Referenced Files
F3414873: D4064.diff
Thu, Dec 5, 9:28 AM
F3414637: D4064.diff
Thu, Dec 5, 8:38 AM
F3414361: D4064.diff
Thu, Dec 5, 7:55 AM
F3414003: D4064.diff
Thu, Dec 5, 7:11 AM
F3413810: D4064.diff
Thu, Dec 5, 6:28 AM
F3413626: D4064.diff
Thu, Dec 5, 5:44 AM
F3413441: D4064.diff
Thu, Dec 5, 5:00 AM
F3413081: D4064.diff
Thu, Dec 5, 4:17 AM

Details

Summary

Update clang-format to v1.8.0 since 1.7.0 does not work on Intel

Test Plan

Check that yarn clang-format-all works on Intel mac

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added 1 blocking reviewer(s): ashoat.
tomek added inline comments.
native/ios/Comm/CommSecureStore.mm
31 ↗(On Diff #12806)

It's really interesting why the code that isn't properly formatted happened to be landed

yarn.lock
15692 ↗(On Diff #12806)

(This is because of https://github.com/CommE2E/comm/commit/33f1104ae4759296ae9f7cc1601ee0602086e06a. I ran yarn cleaninstall before landing to make sure no changes showed up in working copy... but then when I ran yarn cleaninstall this morning the change removing shelljs@^0.8.5 showed up in my working copy. Pretty likely it was an omission on my end, but I'm typically pretty paranoid about running yarn cleaninstall once or twice to make sure yarn.lock has everything in it.)

This revision is now accepted and ready to land.May 17 2022, 12:47 PM