Page MenuHomePhabricator

[services] Backup - Use Add Attachment Reactor
AbandonedPublic

Authored by karol on May 19 2022, 3:07 AM.
Tags
None
Referenced Files
F2212902: D4090.diff
Mon, Jul 8, 9:56 AM
F2210244: D4090.id12936.diff
Sun, Jul 7, 9:53 PM
Unknown Object (File)
Sat, Jul 6, 11:29 PM
Unknown Object (File)
Wed, Jul 3, 7:35 PM
Unknown Object (File)
Wed, Jul 3, 5:24 PM
Unknown Object (File)
Wed, Jul 3, 4:39 PM
Unknown Object (File)
Wed, Jul 3, 3:25 PM
Unknown Object (File)
Wed, Jul 3, 10:14 AM

Details

Reviewers
tomek
ashoat
Summary

Depends on D4089

Finally, using the add attachment reactor in the backup service.

Test Plan
  • terminal 1
cd services
yarn run-blob-service-dev-mode
  • terminal 2
cd services
yarn run-backup-service-dev-mode
  • terminal 3
git clone https://github.com/karol-bisztyga/grpc-playground.git
cd grpc-playground
git checkout backup-async
./build.sh
./cmake/build/bin/client
  • in terminal 3 create a new backup
n
  • in terminal 3 create a new log
l
  • in terminal 3, in order to append a new attachment holder to the backup, use the command b and for the log - k. After doing all this, check the target backup/log item in the database and see that the attachmentHolders filed is updated (for both items this field has the same name).

Diff Detail

Repository
rCOMM Comm
Branch
append-holder
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

karol edited the test plan for this revision. (Show Details)
karol added a reviewer: tomek.
karol edited the summary of this revision. (Show Details)

adding this method to tests

ashoat requested changes to this revision.May 24 2022, 12:16 PM

As discussed in the proto diff, this API should not be in the backup service

This revision now requires changes to proceed.May 24 2022, 12:16 PM