Add a new route for danger zone. It looks like this is the first time we introduce a route consisting of two words, but using hyphens sounds like a better approach compared to underscores.
Depends on D4091
Details
Details
Open settings and check if two nav items are displayed. Try switching between them - always the active should be highlighted. When danger zone is opened, an empty page should be displayed.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ENG-835
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/sidebar/settings-switcher.react.js | ||
|---|---|---|
| 17 | This whitespace change is intentional: we're grouping callbacks and items together for each tab | |
| web/sidebar/settings-switcher.react.js | ||
|---|---|---|
| 46 | Lines 18-35 and 37-54 are grouped together: each group contains a callback and navigation item. For me it makes sense to keep this grouping. Do you suggest this code would be more readable if every variable declaration was separated by a newline from another? I don't think it is a good idea, but if you feel strongly I can do that. | |
Comment Actions
@ashoat I'm adding a new route here and wanted to make sure that you're ok with /danger-zone