Page MenuHomePhabricator

[keyserver] Specify host to mysqldump
ClosedPublic

Authored by ashoat on May 20 2022, 2:55 PM.
Tags
None
Referenced Files
F2834415: D4098.diff
Sat, Sep 28, 11:14 AM
Unknown Object (File)
Sat, Sep 14, 11:21 AM
Unknown Object (File)
Sat, Sep 14, 11:21 AM
Unknown Object (File)
Sat, Sep 14, 11:21 AM
Unknown Object (File)
Thu, Sep 12, 4:30 PM
Unknown Object (File)
Sun, Sep 1, 2:12 AM
Unknown Object (File)
Sun, Sep 1, 2:12 AM
Unknown Object (File)
Sun, Sep 1, 2:12 AM

Details

Summary

Right now it's basically hardcoded to use localhost. We have this config in DBConfig, so we should use it. This will make the backup work if the database is not local.

Depends on D4097

Test Plan
  1. I checked mysqldump --help | grep host on both my local macOS as well as on the prod server and it looks like it's definitely -h
  2. I tested the backup cronjob by modifying the time config
  3. I tested localhost to make sure it works as an alias to 127.0.0.1

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable