Page MenuHomePhabricator

[keyserver] Make importJSON check env variables
ClosedPublic

Authored by ashoat on May 23 2022, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 2:57 AM
Unknown Object (File)
Nov 15 2024, 3:41 PM
Unknown Object (File)
Nov 13 2024, 10:51 AM
Unknown Object (File)
Nov 8 2024, 8:09 PM
Unknown Object (File)
Nov 6 2024, 11:29 PM
Unknown Object (File)
Oct 28 2024, 2:49 AM
Unknown Object (File)
Oct 26 2024, 8:16 PM
Unknown Object (File)
Oct 26 2024, 8:16 PM

Details

Summary

As we Dockerize the keyserver, we need to make it possible to define config via environmental variables. This is a standard practice in Docker for specifying config/secrets.

Currently we specify config/secrets to Node via JSON files that get imported directly. In previous diffs in the stack, I've refactored all of these codepaths to go through importJSON. In this diff, I make it possible for importJSON to get the config from environmental variables rather than JSON files.

Depends on D4101

Test Plan

I tested this diff in combination with the next one. See the test plan there

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 23 2022, 1:02 PM