Paths

Table of Contentst

Differential D4102

[keyserver] Make importJSON check env variables
ClosedPublic
Actions

Authored by ashoat on May 23 2022, 7:26 AM.

Tags

None

Referenced Files

	F3249515: D4102.diff
	Fri, Nov 15, 3:41 PM

	Unknown Object (File)
	Wed, Nov 13, 10:51 AM

	Unknown Object (File)
	Fri, Nov 8, 8:09 PM

	Unknown Object (File)
	Wed, Nov 6, 11:29 PM

	Unknown Object (File)
	Mon, Oct 28, 2:49 AM

	Unknown Object (File)
	Sat, Oct 26, 8:16 PM

	Unknown Object (File)
	Sat, Oct 26, 8:16 PM

	Unknown Object (File)
	Oct 5 2024, 1:42 AM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMM5d78d6550580: [keyserver] Make importJSON check env variables

Summary

As we Dockerize the keyserver, we need to make it possible to define config via environmental variables. This is a standard practice in Docker for specifying config/secrets.

Currently we specify config/secrets to Node via JSON files that get imported directly. In previous diffs in the stack, I've refactored all of these codepaths to go through importJSON. In this diff, I make it possible for importJSON to get the config from environmental variables rather than JSON files.

Depends on D4101

Test Plan

I tested this diff in combination with the next one. See the test plan there

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 23 2022, 7:26 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 23 2022, 7:26 AM

ashoat added a child revision: D4103: [keyserver] Add MySQL config to docker-compose.yml.May 23 2022, 7:28 AM

Harbormaster completed remote builds in B9391: Diff 13010.May 23 2022, 7:32 AM

ashoat requested review of this revision.May 23 2022, 7:32 AM

atul accepted this revision.May 23 2022, 1:02 PM

This revision is now accepted and ready to land.May 23 2022, 1:02 PM

Closed by commit rCOMM5d78d6550580: [keyserver] Make importJSON check env variables (authored by ashoat). · Explain WhyMay 24 2022, 6:10 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5d78d6550580: [keyserver] Make importJSON check env variables.

ashoat mentioned this in D4150: [keyserver] Add facts/secrets folder to .dockerignore.May 30 2022, 1:19 PM

ashoat mentioned this in rCOMM3e900b7ad236: [keyserver] Add facts/secrets folder to .dockerignore.May 31 2022, 5:50 AM

ashoat mentioned this in D4171: [keyserver] Fix importJSON environmental variables to avoid special chars in name.Jun 1 2022, 1:29 AM

ashoat mentioned this in rCOMMa407cad3a87d: [keyserver] Fix importJSON environmental variables to avoid special chars in….Jun 1 2022, 10:56 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

8 lines

Diff 13010

keyserver/src/utils/import-json.js

Loading...