Paths

Table of Contentst

-
web/modals/threads/notifications/
-
modals/
-
threads/
-
notifications/
-
notifications-modal.react.js

Differential D4109

[web] Pull "statement" constants out of `NotificationsModal`
ClosedPublic
Actions

Authored by atul on May 23 2022, 2:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 1, 2:42 PM

	Unknown Object (File)
	Mon, Mar 31, 8:49 PM

	Unknown Object (File)
	Mon, Mar 31, 5:11 PM

	Unknown Object (File)
	Mon, Mar 31, 7:47 AM

	Unknown Object (File)
	Mon, Mar 31, 5:22 AM

	Unknown Object (File)
	Mon, Mar 31, 3:40 AM

	Unknown Object (File)
	Mon, Mar 31, 2:50 AM

	Unknown Object (File)
	Mar 3 2025, 6:46 PM

Subscribers

Details

Reviewers

• jacek
tomek
• benschac

Commits

rCOMM273f666112ca: [web] Pull "statement" constants out of `NotificationsModal`

Summary

Addresses feedback from @palys-swm in D4048: https://phabricator.ashoat.com/D4048#114268
Linear Issue: https://linear.app/comm/issue/ENG-1173/pull-statement-constants-out-of-notificationsmodal

Test Plan

Open NotificationsModal and ensure that things continue to look as expected.

Diff Detail

Repository

Branch

landmay24 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 23 2022, 2:02 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 23 2022, 2:02 PM

atul added inline comments.May 23 2022, 2:03 PM

web/modals/threads/notifications/notifications-modal.react.js
33 ↗	(On Diff #13022)	intentional

Harbormaster completed remote builds in B9402: Diff 13022.May 23 2022, 2:07 PM

atul requested review of this revision.May 23 2022, 2:07 PM

tomek accepted this revision.May 24 2022, 2:15 AM

This revision is now accepted and ready to land.May 24 2022, 2:15 AM

rebase before landing

Harbormaster completed remote builds in B9435: Diff 13070.May 24 2022, 6:35 AM

Closed by commit rCOMM273f666112ca: [web] Pull "statement" constants out of `NotificationsModal` (authored by atul). · Explain WhyMay 24 2022, 6:36 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM273f666112ca: [web] Pull "statement" constants out of `NotificationsModal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

notifications/

notifications-modal.react.js

45 lines

Diff 13070

web/modals/threads/notifications/notifications-modal.react.js

	Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines		keyserverInfos: {
	: 'https://web.comm.app',			: 'https://web.comm.app',
	connection: { ...defaultConnectionInfo },			connection: { ...defaultConnectionInfo },
	lastCommunicatedPlatformDetails: null,			lastCommunicatedPlatformDetails: null,
	},			},
	},			},
	},			},
	threadActivityStore: {},			threadActivityStore: {},
	initialStateLoaded: false,			initialStateLoaded: false,
				integrityStore: { threadHashes: {}, threadHashingStatus: 'starting' },
	});			});

	export { defaultWebState };			export { defaultWebState };