Try to improve the style of the modal and make it consistent with e.g. password modal. There are no designs for this modal, so any advices will be really appreciated.
Depends on D4118
Details
Details
- Reviewers
• jacek atul • benschac - Commits
- rCOMM4bcf1d0d76cc: [web] Restyle delete account modal
Open the modal and check if it is displayed correctly.
Click Delete Account and check if an unknown error is displayed.
Type an incorrect password, click Delete Account and check if wrong password error is displayed.
Type a correct password, click the button and verify that the account was deleted.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/settings/account-delete-modal.react.js | ||
|---|---|---|
| 74 | Without this break the text is displayed in a way where just this. is in the second line. | |
Comment Actions
There are no designs for this modal, so any advices will be really appreciated.
It might be worth looking at the ThreadSettingsModalDeleteTab for inspiration? There weren't any designs for that either... but it's probably worth keeping them consistent?
| web/settings/account-delete-modal.react.js | ||
|---|---|---|
| 74 | Instead of using the <br/ > tag, could we split the text into two separate <p> tags? It might be a little more work getting the vertical height between the sentences right, but I think it could be a cleaner solution. IIRC we should avoid using <br /> and <hr /> for layout if at all possible? | |
Comment Actions
@atul thanks for the suggestion! Could you check if it looks ok, and suggest any other improvements?
Note: haven't followed button width from ThreadSettingsModalDeleteTab because here we need to display an error. (we can display the error above the button, but changing modal height doesn't sound the best).
Comment Actions
@atul thanks for the suggestion! Could you check if it looks ok, and suggest any other improvements?
Looks good to me!