Page MenuHomePhabricator
Differential D4124

[web] Add a rectangle next to settings icon when settings page is opened
ClosedPublic
Actions

Authored by tomek on May 25 2022, 6:44 AM.
Tags
None
Referenced Files
F3378994: D4124.diff
Wed, Nov 27, 2:34 PM
Unknown Object (File)
Sat, Nov 16, 10:08 AM
Unknown Object (File)
Thu, Nov 14, 4:38 PM
Unknown Object (File)
Thu, Nov 14, 4:38 PM
Unknown Object (File)
Tue, Oct 29, 12:13 AM
Unknown Object (File)
Oct 28 2024, 3:02 AM
Unknown Object (File)
Oct 28 2024, 3:02 AM
Unknown Object (File)
Oct 28 2024, 3:02 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
atul
• benschac
Commits
rCOMM1fb2988aee0f: [web] Add a rectangle next to settings icon when settings page is opened
Summary

When settings page is opened we should mark it by adding a rectangle next to the icon in bottom-left corner. https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1272%3A88750

settings_open_margins.png (284×638 px, 37 KB)

settings_open.png (178×202 px, 7 KB)

chat_open.png (140×200 px, 7 KB)

Depends on D4121

Test Plan

Open chat and check if the rectangle is not displayed. Open settings and check if the rectangle is there (on both account and danger-zone pages).

Diff Detail

Repository
rCOMM Comm
Branch
ENG-835
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 25 2022, 6:44 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 25 2022, 6:44 AM
tomek edited the summary of this revision. (Show Details)May 25 2022, 6:45 AM
Harbormaster completed remote builds in B9467: Diff 13118.May 25 2022, 6:51 AM
tomek requested review of this revision.May 25 2022, 6:51 AM
atul added a comment.May 25 2022, 10:21 AM

Nice, patched it and it looks just like the designs in Figma

fae3.png (172×184 px, 8 KB)

web/sidebar/community-picker.react.js
27

Maybe isSettingsOpen?

atul accepted this revision.May 25 2022, 10:21 AM
This revision is now accepted and ready to land.May 25 2022, 10:21 AM
tomek added inline comments.May 26 2022, 9:51 AM
web/sidebar/community-picker.react.js
27

Not sure, for me are sounds better because settings are plural. But it is likely that for a native speaker is is better. Are you sure is is a better option?

ashoat added inline comments.May 26 2022, 12:04 PM
web/sidebar/community-picker.react.js
27

This is probably a US English vs British English distinction. Both are fine imo

tomek updated this revision to Diff 13164.May 27 2022, 8:18 AM

Rename

Harbormaster completed remote builds in B9506: Diff 13164.May 27 2022, 8:25 AM
tomek added a child revision: D4144: [web] Open chat when user clicks inbox icon.May 27 2022, 8:57 AM
Closed by commit rCOMM1fb2988aee0f: [web] Add a rectangle next to settings icon when settings page is opened (authored by tomek). · Explain WhyMay 30 2022, 2:56 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM1fb2988aee0f: [web] Add a rectangle next to settings icon when settings page is opened.

Revision Contents
Changeset List

PathSize
web/
sidebar/
9 lines
17 lines
1 line

Diff 13118

View Options

web/sidebar/community-picker.css

Loading...
View Options

web/sidebar/community-picker.react.js

Loading...
View Options

web/theme.css

Loading...