Depends on D4080
Adding parseAttachmentHolders function that splits received attachments by the delimiter and performs some sanity checks.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/backup/src/Tools.cpp | ||
|---|---|---|
| 36–53 ↗ | (On Diff #13141) | This function doesn't make sense for me. We take holders that is a ATTACHMENT_DELIMITER-separated string, then split by ATTACHMENT_DELIMITER and finally construct ATTACHMENT_DELIMITER-separated string again. I think parse function should take a string and return some type of structure. In this case, I would expect that parse function takes a string and returns a vector with strings. It might be possible that the behavior of this function is what was intended - but then we should find a better name, e.g. validateAttachmentHolders. |
| 41 ↗ | (On Diff #13141) | If we assume that ATTACHMENT_DELIMITER is one char long, maybe we should use char instead? |
| services/backup/src/Tools.cpp | ||
|---|---|---|
| 42–44 ↗ | (On Diff #13155) | Are you sure we need to throw here? What if an id is something like aaa::bbb? |
| services/backup/src/Tools.cpp | ||
|---|---|---|
| 42–44 ↗ | (On Diff #13155) | Sorry, my comment doesn't make sense - please ignore it. |