Paths

Table of Contentst

Differential D4134

[services] Backup - Database Items - Update attachment methods
ClosedPublic
Actions

Authored by • karol on May 26 2022, 10:06 AM.

Details

Reviewers

tomek

Commits

rCOMMb1e5cf1be08c: [services] Backup - Database Items - Update attachment methods

Summary

Depends on D4133

Renaming appendAttachmentHolder to addAttachmentHolders for consistency and using tools::parseAttachmentHolders in both BackupItem and LogItem.

Test Plan

Services can still be built normally. For a full test plan of this functionality, please see D4135

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.May 26 2022, 10:06 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 26 2022, 10:06 AM

• karol edited the summary of this revision. (Show Details)May 26 2022, 10:15 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D4133: [services] Backup - Tools - validate attachment holders.

• karol added a child revision: D4135: [services] Backup - Add Attachment Reactor Logic.May 26 2022, 10:25 AM

Harbormaster completed remote builds in B9488: Diff 13142.May 26 2022, 10:26 AM

• karol requested review of this revision.May 26 2022, 10:26 AM

• karol planned changes to this revision.May 27 2022, 1:45 PM

rebase

Harbormaster completed remote builds in B9502: Diff 13156.May 27 2022, 1:58 PM

tomek accepted this revision.May 30 2022, 11:44 AM

This revision is now accepted and ready to land.May 30 2022, 11:44 AM

Closed by commit rCOMMb1e5cf1be08c: [services] Backup - Database Items - Update attachment methods. · Explain WhyMay 30 2022, 4:13 PM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMb1e5cf1be08c: [services] Backup - Database Items - Update attachment methods.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

DatabaseEntities/

2 lines

8 lines

2 lines

8 lines

Diff 13211

View Options

services/backup/src/DatabaseEntities/BackupItem.h

View Options

services/backup/src/DatabaseEntities/BackupItem.cpp

View Options

services/backup/src/DatabaseEntities/LogItem.h

View Options

services/backup/src/DatabaseEntities/LogItem.cpp

[services] Backup - Database Items - Update attachment methodsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13211

services/backup/src/DatabaseEntities/BackupItem.h

services/backup/src/DatabaseEntities/BackupItem.cpp

services/backup/src/DatabaseEntities/LogItem.h

services/backup/src/DatabaseEntities/LogItem.cpp

[services] Backup - Database Items - Update attachment methods
ClosedPublic
Actions

Revision Contents
Changeset List