Page MenuHomePhabricator

[keyserver] Add facts/secrets folder to .dockerignore
ClosedPublic

Authored by ashoat on May 30 2022, 1:19 PM.
Tags
None
Referenced Files
F2019908: D4150.id13223.diff
Sun, Jun 16, 1:51 PM
F2019907: D4150.id.diff
Sun, Jun 16, 1:51 PM
F2019906: D4150.id13213.diff
Sun, Jun 16, 1:51 PM
F2019810: D4150.diff
Sun, Jun 16, 1:06 PM
Unknown Object (File)
Fri, Jun 14, 10:48 PM
Unknown Object (File)
Fri, Jun 14, 7:53 AM
Unknown Object (File)
Thu, Jun 13, 6:47 PM
Unknown Object (File)
Wed, Jun 12, 4:00 AM

Details

Summary

Following D4102 and D4103, these values get passed into the Docker container via environmental variables. We should avoid any confusion here, and avoid accidentally leaking any secrets.

Test Plan

Create a keyserver/.env file, eg.:

COMM_MYSQL_DATABASE=commdev
COMM_MYSQL_USER=commdev
COMM_MYSQL_PASSWORD=pass

And then make sure the Docker image still works: docker-compose down -v && docker-compose up --build

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/dockerize_node
Lint
No Lint Coverage
Unit
No Test Coverage