[DRAFT] [services] Tests - Add to docker compose
AbandonedPublic
Actions

Authored by • karol on May 31 2022, 6:49 AM.

Details

Reviewers

tomek
varun
ashoat

Summary

Depends on D4162

Adding docker-compose for the testing service. Nothing fancy here, mostly copied from the other services.

Test Plan

cd services
docker-compose up commtest-server

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.May 31 2022, 6:49 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 31 2022, 6:49 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 31 2022, 6:54 AM

Harbormaster failed remote builds in B9542: Diff 13236!

• karol edited the summary of this revision. (Show Details)May 31 2022, 7:05 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, ashoat, varun.

• karol added a parent revision: D4162: [DRAFT] [services] Tests - Add Dockerfile.

• karol added a child revision: D4164: [services] Tests - Add backup utils.

Harbormaster returned this revision to the author for changes because remote builds failed.May 31 2022, 7:26 AM

Harbormaster failed remote builds in B9554: Diff 13248!

I know that Ci failed but it's related to docker which I know is not working properly right now.

Seems good to me, but I'm a bit confused about why we need Docker. Resigning here – we can discuss in D4161

tomek accepted this revision.Jun 1 2022, 6:30 AM

LGTM, but also curious if we really need to Dockerize our testing service

This revision is now accepted and ready to land.Jun 1 2022, 9:54 AM

Yes, we can resign from docker here I think.

• karol abandoned this revision.Jun 6 2022, 4:35 AM

• karol removed a child revision: D4164: [services] Tests - Add backup utils.Jun 13 2022, 4:39 AM

Revision Contents
Changeset List

Path

Size

services/

docker-compose.yml

14 lines

Diff 13236

View Options

services/docker-compose.yml

[DRAFT] [services] Tests - Add to docker composeAbandonedPublicActions